Review main Merged

62599[TASK] Update rector/rector

Alexander Schnitzler CR +2 V +2 Hard +252 −529 updated 12/19/19, 13:47

Commit message

composer remove --dev rector/rector
    composer require --dev rector/rector:~0.6

The update of rector brings important bugfixes and
enables the installation of the latest version of
phpstan/phpstan.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1015

  1. Alexander Schnitzler uploaded patch set 1 12/11/19, 12:01

  2. Alexander Schnitzler wrote 12/11/19, 12:01

    Topic set to rector
  3. Alexander Schnitzler uploaded patch set 2 12/11/19, 12:04

  4. TYPO3com voted on patch set 1 V +1 12/11/19, 12:45 Completed build in 44m 08s on Wed, 11 Dec, 12:45 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39330

  5. TYPO3com voted on patch set 2 V +1 12/11/19, 13:11 Completed build in 1h 05m 59s on Wed, 11 Dec, 01:11 PM Test Summary: 68713 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39332

  6. Alexander Schnitzler updated the commit message in patch set 3 12/11/19, 13:22

  7. TYPO3com voted on patch set 3 V +1 12/11/19, 13:47 Completed build in 25m 22s on Wed, 11 Dec, 01:47 PM Test Summary: 68710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39336

  8. Alexander Schnitzler uploaded patch set 4 12/19/19, 08:44

  9. TYPO3com voted on patch set 4 V -1 12/19/19, 08:52 Completed build in 08m 08s on Thu, 19 Dec, 08:52 AM Test Summary: 68566 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39525

  10. Oliver Klee commented on patch set 4 12/19/19, 10:10

    composer.json:80

    Why ~ instead of ^ ?
  11. TYPO3com voted on patch set 4 V +1 12/19/19, 10:15 Completed build in 1h 39m 17s on Thu, 19 Dec, 10:15 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39525

  12. Alexander Schnitzler commented on patch set 4 12/19/19, 10:16

    composer.json:80 Reply Unresolved

    Does not really matter imho. According to semver, we should be safe using all further versions up until 0.9.99.
  13. Andreas Kienast voted on patch set 4 V +1 CR +1 12/19/19, 10:49

  14. Anja Leichsenring voted on patch set 4 V +2 CR +2 12/19/19, 13:47

  15. Anja Leichsenring merged patch set 5 12/19/19, 13:47