Review main Abandoned

62601[TASK] Harden QOM interfaces and classes

Alexander Schnitzler CR 0 V 0 Hard +357 −186 updated 03/17/23, 14:24

Commit message

The QOM (Query Object Model) implementation in Extbase,
originally taken from the JCR (Java Content Repository),
has been hardened by adding type hints to the interfaces
and classes.

Unfortunately one cannot simply apply the type hints
found in the source code of java because over the years
the interfaces have been violated. Some implementations
only work with optional parameters or with mixed types
for example.

The goal of this patch is to stay in sync with the java
source code as much as possible on the one hand and not
to break the current implementation on the other.

A possible refactoring will take place in another patch.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 33

Show 13 more files

Review log 2643

Show 918 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 12/11/19, 18:14

  2. TYPO3com voted on patch set 1 V -1 12/11/19, 18:40 Completed build in 25m 45s on Wed, 11 Dec, 06:40 PM Test Summary: 1116 of 69073 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39345

  3. Alexander Schnitzler uploaded patch set 2 12/12/19, 09:39

  4. TYPO3com voted on patch set 2 V -1 12/12/19, 09:58 Completed build in 18m 22s on Thu, 12 Dec, 09:58 AM Test Summary: 492 of 35729 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39355

  5. TYPO3com commented on patch set 2 12/12/19, 10:18 Completed build in 56m 25s on Thu, 12 Dec, 10:18 AM Test Summary: 552 of 68395 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39355

  6. TYPO3com commented on patch set 2 12/12/19, 14:25 Completed build in 5h 42m 08s on Thu, 12 Dec, 02:25 PM Test Summary: 527 of 68908 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39355

  7. Alexander Schnitzler wrote 12/12/19, 15:03

    Topic set to extbase
  8. Alexander Schnitzler uploaded patch set 3 12/12/19, 15:58

  9. Oliver Klee commented on patch set 3 12/12/19, 16:00

    AndInterface.php:37

    This comment then needs to be updated accordingly.

    LogicalAnd.php:72 Unresolved

    This comment then needs to be updated accordingly.

    Selector.php:58 Unresolved

    This comment then needs to be updated accordingly.

    Selector.php:69 Unresolved

    This comment then needs to be updated accordingly.

    SelectorInterface.php:35 Unresolved

    This comment then needs to be updated accordingly.

    SelectorInterface.php:43 Unresolved

    This comment then needs to be updated accordingly.
  10. Alexander Schnitzler uploaded patch set 4 12/12/19, 16:18

  11. TYPO3com voted on patch set 3 V -1 12/12/19, 16:19 Completed build in 20m 25s on Thu, 12 Dec, 04:19 PM Test Summary: 7 of 68656 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39367

  12. Alexander Schnitzler uploaded patch set 5 12/12/19, 16:38

  13. TYPO3com voted on patch set 4 V +1 12/12/19, 16:39 Completed build in 20m 41s on Thu, 12 Dec, 04:39 PM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39368

  14. TYPO3com voted on patch set 5 V +1 12/12/19, 16:46 Completed build in 07m 36s on Thu, 12 Dec, 04:46 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39369

  15. TYPO3com commented on patch set 3 12/12/19, 17:09 Completed build in 1h 31m 15s on Thu, 12 Dec, 05:09 PM Test Summary: 5 of 68911 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39367

  16. Alexander Schnitzler uploaded patch set 6 12/12/19, 18:24

  17. TYPO3com voted on patch set 6 V -1 12/12/19, 18:27 Completed build in 02m 50s on Thu, 12 Dec, 06:27 PM Test Summary: 3 of 375 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39371

  18. Alexander Schnitzler uploaded patch set 7 12/12/19, 18:42

  1. TYPO3com voted on patch set 7 V -1 12/12/19, 18:52 Completed build in 10m 04s on Thu, 12 Dec, 06:52 PM Test Summary: 1039 of 69167 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39374

  2. Alexander Schnitzler uploaded patch set 8 12/12/19, 18:54

  3. TYPO3com voted on patch set 8 V -1 12/12/19, 19:02 Completed build in 07m 55s on Thu, 12 Dec, 07:02 PM Test Summary: 58622 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39375

  4. TYPO3com voted on patch set 8 V +1 12/12/19, 19:28 Completed build in 42m 09s on Thu, 12 Dec, 07:28 PM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39375

  5. Alexander Schnitzler uploaded patch set 9 12/13/19, 08:24

  6. TYPO3com voted on patch set 9 V +1 12/13/19, 08:35 Completed build in 10m 50s on Fri, 13 Dec, 08:35 AM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39382

  7. Alexander Schnitzler updated the commit message in patch set 10 12/13/19, 08:43

  8. Alexander Schnitzler commented on patch set 10 12/13/19, 08:45

    AndInterface.php:37 Reply Unresolved

    Thanks for you early review but the patch wasn't quite ready yet yesterday and newer patch sets render your comments invalid as the idea is to reflect the original source code instead of reality. There will be more patches in the future making sure that the original type hints and comments are valid again.
  9. TYPO3com voted on patch set 10 V +1 12/13/19, 08:57 Completed build in 13m 49s on Fri, 13 Dec, 08:57 AM Test Summary: 68711 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39383

  10. Markus Klein commented on patch set 10 12/17/19, 19:26

    Comparison.php:142

    can't we add array as typehint for $boundVariables?

    Join.php:48

    IMO we can remove all those infos. with the typehint we know that this can't be the case.

    LowerCase.php:50

    I don't get why this is the case
  11. Markus Klein commented on patch set 10 CR -1 12/17/19, 19:28

    Needs a breaking rst for the changes of the constant values

    QueryInterface.php:30

    That's a breaking change.
  12. Alexander Schnitzler commented on patch set 10 12/17/19, 19:48

    Comparison.php:142 Reply Unresolved

    I don't know at the moment. I would need to test that again. Will do so tomorrow.

    Join.php:48 Reply Unresolved

    We could, yes. But when looking at the original JCR implementation you see that we implemented things differently and this patch is meant to harden the classes and interfaces as much as possible while having the original and our code base in mind. The idea is to adjust our code base later.

    LowerCase.php:50 Reply Unresolved

    Due to the support of return type covariance. We took this code from java, about 10 years ago when java alread knew covariant return types whereas PHP learnt that in 7.4.

    QueryInterface.php:30 Reply

    I disagree. There is no use case where people would use those constants directly. They are only used in internal classes and are not exposed to the user at all.
  13. Markus Klein commented on patch set 10 CR 0 12/17/19, 19:55

    QueryInterface.php:30 Reply

    The problem is that we would have to proof that, which we can't. We don't know if someone used this for some reason. NO comment says somewhere that this was introduced for internal usage only. Don't get me wrong, I also don't see a use case, but history of breaking changes tells us a different story. I won't be in the way, and will remove my -1.
  14. Alexander Schnitzler commented on patch set 10 12/17/19, 20:02

    QueryInterface.php:30 Reply Unresolved

    The problem is, that at one point in time, we switched from @api to @internal and in Extbase a lot of @internal's haven't been set in the change. So, technically 99% of Extbase is api if we only look at annotations. Defining api like that is madness. Of course we never know if people use something. They could use this constant to represent an integer 1 in a different context. But in those cases#. Bad luck. If there is someone who proves that these constants are possibly used because our other api demands that, I will back off.
  15. Alexander Schnitzler uploaded patch set 11 01/25/20, 10:20

  16. TYPO3com voted on patch set 11 V -1 01/25/20, 10:30 Completed build in 09m 49s on Sat, 25 Jan, 10:30 AM Test Summary: 6 of 71031 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40206

  17. Alexander Schnitzler updated the commit message in patch set 12 01/25/20, 10:31

  18. TYPO3com voted on patch set 12 V -1 01/25/20, 10:46 Completed build in 14m 13s on Sat, 25 Jan, 10:46 AM Test Summary: 6 of 71031 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40207

  19. Alexander Schnitzler marked it work in progress 02/28/20, 15:59

  20. Benni Mack wrote 11/29/21, 10:01

    Change destination moved from master to main
  21. Benni Mack updated the commit message in patch set 13 11/29/21, 13:16

  22. Oliver Klee uploaded patch set 14 07/02/22, 14:41

  23. Oliver Klee commented on patch set 14 CR -1 07/02/22, 14:42

    Only rebased. We need to clean this up and split it up into smaller changes.
  24. core-ci voted on patch set 14 V -1 07/02/22, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28612

  25. Alexander Schnitzler abandoned the change 03/17/23, 14:24

    Unable to solve this pragmatically, no feedback for months.