Review main Merged

62602[BUGFIX] Name "default language" consistently

Benni Mack CR +2 V +2 Easy +9 −9 updated 12/13/19, 18:25

Commit message

When working with the "pages.l18n_cfg" bitset flag, there is an
option "default translation", which commonly refers to language
with sys_language_uid=0. In most other cases, also in various
documentation pieces, the naming is "default language" instead
of "default translation" which is more correct in this case.

All places are now properly named "default language"
and no "default translation" is there anymore, making the
functionality more consistent.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 812

  1. Benni Mack uploaded patch set 1 12/12/19, 06:34

  2. TYPO3com voted on patch set 1 V -1 12/12/19, 06:34 Completed build in 12s on Thu, 12 Dec, 06:34 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39350

  3. TYPO3com commented on patch set 1 12/12/19, 06:55 Completed build in 21m 38s on Thu, 12 Dec, 06:55 AM Test Summary: 68449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39350

  4. TYPO3com commented on patch set 1 12/12/19, 07:09 Completed build in 57m 16s on Thu, 12 Dec, 07:09 AM Test Summary: 68449 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39350

  5. Susi Moog commented on patch set 1 12/12/19, 07:11

    locallang_csh_webinfo.xlf:88 Unresolved

    missed one.
  6. Benni Mack commented on patch set 2 12/12/19, 18:32

    Published edit on patch set 1.
  7. TYPO3com voted on patch set 2 V +1 12/12/19, 19:06 Completed build in 33m 14s on Thu, 12 Dec, 07:06 PM Test Summary: 68710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39373

  8. Oli Bartsch voted on patch set 2 CR +1 12/13/19, 06:36

  9. Alexander Schnitzler voted on patch set 2 V +1 CR +1 12/13/19, 13:57

  10. Oli Bartsch voted on patch set 2 V +1 12/13/19, 17:42

  11. Georg Ringer voted on patch set 2 V +2 CR +2 12/13/19, 18:25

  12. Georg Ringer merged patch set 3 12/13/19, 18:25