62604[TASK] Remove unused imports
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
- TYPO3com +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Controller/File/ThumbnailController.php+0 −1
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/TtContentRepository.php+0 −2
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/Storage/Typo3DbBackendTest.php+0 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderAllFormValuesViewHelper.php+0 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+0 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Fixtures/CodeStatisticsFixture.php+0 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/FunctionCallMatcherFixture.php+0 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodArgumentRequiredMatcherFixture.php+0 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/MethodCallMatcherFixture.php+0 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/FunctionCallMatcherTest.php+1 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+2 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/CodeStatisticsTest.php+1 −1
Review log 1416
-
Oli Bartsch uploaded patch set 1 12/12/19, 10:14
-
Benni Mack commented on patch set 1 12/12/19, 10:27
did you do this manually? -
Oli Bartsch commented on patch set 1 12/12/19, 10:30
> Patch Set 1: > > did you do this manually? I run PHPStorm "Optimize imports" and checked each result for plausibility and correctness. -
Oliver Klee voted on patch set 1 CR +1 12/12/19, 10:31
-
TYPO3com voted on patch set 1 V -1 12/12/19, 10:42 Completed build in 27m 08s on Thu, 12 Dec, 10:42 AM Test Summary: 25 of 67912 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39357
-
Alexander Schnitzler commented on patch set 1 12/12/19, 10:49
I wonder why php-cs-fixer didn't find these via no_unused_imports... -
Oli Bartsch uploaded patch set 2 12/12/19, 11:11
-
Oli Bartsch commented on patch set 2 12/12/19, 11:15
> Patch Set 1: > > I wonder why php-cs-fixer didn't find these via no_unused_imports... Maybe we should have a look there too. I just was in one of these classes and also wondered why there was an unused import. Then searched the whole `sysext` for it. -
TYPO3com voted on patch set 2 V +1 12/12/19, 11:39 Completed build in 27m 46s on Thu, 12 Dec, 11:39 AM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39359
-
Benni Mack commented on patch set 2 12/12/19, 15:54
yes, php-cs-fixer only looks at the PHP changes of the last commit with cglFixMyCommit.sh - so it would be really cool if you run php-cs-fixer completely again and see if there are more parts missing. -
Alexander Schnitzler commented on patch set 2 12/12/19, 15:57
> Patch Set 2: > > yes, php-cs-fixer only looks at the PHP changes of the last commit with cglFixMyCommit.sh - so it would be really cool if you run php-cs-fixer completely again and see if there are more parts missing. Even when running php-cs-fixer manually, it doesn't detect these changes. -
Oli Bartsch commented on patch set 2 12/13/19, 06:52
I also run php-cs-fixer manually by removing the cache beforehand and it didn't detect these files at all. -
Alexander Schnitzler voted on patch set 2 V +1 CR +1 12/13/19, 13:53
-
Oliver Klee voted on patch set 2 CR +1 12/13/19, 14:35
-
Benni Mack voted on patch set 2 V +2 CR +2 12/13/19, 15:58
-
Benni Mack merged patch set 3 12/13/19, 16:01