Review main Abandoned

62608[BUGFIX] Only last postProcContent-hook is applied

TYPO3com CR 0 V 0 Easy +1 −0 updated 01/25/20, 15:43

Commit message

postProcContent-hooks are used to update page content before it is sent
to the browser, e.g. by processing extra item markers.
When a hook is called, the current page content is passed as parameter
$_params and the modified content is returned by the hook.
Unfortunately the $_params-object is not updated in the loop which
calls all hooks. Each hook is called with the initial page content, and
only the return value of the last hook is returned as the overall
result  (i.e. final page content).

This change updates the $_params-object in each iteration, so each hook-
function is called with the updated content of the previous hook. This
ensures that the modifications of all hooks are applied and not only
the modifications of the last hook.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 12/12/19, 14:33

  2. TYPO3com voted on patch set 1 V +1 12/12/19, 14:42 Completed build in 08m 52s on Thu, 12 Dec, 02:42 PM Test Summary: 68710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39364

  3. Susi Moog voted on patch set 1 CR +1 12/15/19, 15:33

  4. Jan Stockfisch commented on patch set 1 CR -1 12/16/19, 18:36

    duplicated by https://review.typo3.org/c/Packages/TYPO3.CMS/+/62325 and IMO that would be the correct way to solve this bug
  5. Susi Moog abandoned the change 01/25/20, 15:43