Review main Merged

62616[TASK] Remove dead code from Extbase persistence

Alexander Schnitzler CR +2 V +2 Hard +145 −293 updated 12/22/20, 07:20

Commit message

This patch removes unused code in the persistence
area of Extbase. Most removed code was part of
internal classes and interfaces, thus they are
removed without notice.

Along with the removal of methods, two methods
have been marked deprecated and for their
removal in the future i.e. TYPO3 12.0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 3140

Show 1115 earlier messages
  1. Alexander Schnitzler uploaded patch set 1 12/13/19, 11:13

  2. Alexander Schnitzler wrote 12/13/19, 11:14

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 12/13/19, 11:41 Completed build in 19m 34s on Fri, 13 Dec, 11:41 AM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39388

  4. Alexander Schnitzler uploaded patch set 2 12/13/19, 13:37

  5. TYPO3com voted on patch set 2 V +1 12/13/19, 13:50 Completed build in 12m 01s on Fri, 13 Dec, 01:50 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39393

  6. Oli Bartsch commented on patch set 2 12/13/19, 14:13

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:15 Unresolved

    Should be removed.

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:21 Unresolved

    TYPO3

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:35 Unresolved

    Maybe add some linebreaks here.
  7. Alexander Schnitzler commented on patch set 3 12/13/19, 15:55

    Published edit on patch set 2.
  8. TYPO3com voted on patch set 3 V -1 12/13/19, 16:07 Completed build in 12m 19s on Fri, 13 Dec, 04:07 PM Test Summary: 68620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39402

  9. TYPO3com voted on patch set 3 V +1 12/13/19, 16:13 Completed build in 30m 45s on Fri, 13 Dec, 04:13 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39402

  10. Markus Klein commented on patch set 3 CR -1 12/17/19, 19:34

    DataMapper.php:613

    IMO this is public API and needs deprecation

    Query.php:640

    this is required by the interface
  11. Markus Klein commented on patch set 3 12/17/19, 19:35

    QueryInterface.php:341

    Breaking change
  12. Alexander Schnitzler commented on patch set 3 12/17/19, 19:57

    DataMapper.php:613 Reply Unresolved

    Why do you think so? This class is an internal class, not meant to be used by users. Why would they want to know if a property is persistable if the core itself doesn't use that method?

    Query.php:640 Reply Unresolved

    Ok, let's leave it in, deprecate it but remove the contract already.

    QueryInterface.php:341 Reply

    Removing a method from an interface is never breaking. Removing an implementation is a different story though, agreed.
  13. Markus Klein commented on patch set 3 12/17/19, 20:22

    QueryInterface.php:341 Reply

    > Removing a method from an interface is never breaking. Hm... if ($a instanceOf QueryInterface) $a->isEmpty($foo); Removing isEmpty() from the Interface is of course a major breaking change. I, as a user of the interface expect the called method to be there.... which suddenly wouldn't be there anymore.
  14. Alexander Schnitzler commented on patch set 3 12/17/19, 21:50

    QueryInterface.php:341 Reply Unresolved

    The code you pasted does not break just because the contract changed. Only if you define a custom query, implementing the interface and relying on the method while changing your own implementation, then it will break. But, it's your responsibility then. As mentioned in the Query class: We can deprecate the method implementation to not be breaking and remove the method contract from the interface right away in a non breaking manner.
  15. Alexander Schnitzler commented on patch set 3 01/25/20, 10:09

    Hi Markus, please continue the discussion or remove your -1 here. You are blocking this patch for a while now without further interaction after my last comment.
  1. Markus Klein voted on patch set 3 CR 0 01/25/20, 18:20

  2. Alexander Schnitzler marked it work in progress 02/28/20, 15:34

  3. Alexander Schnitzler uploaded patch set 4 11/16/20, 15:23

  4. Alexander Schnitzler commented on patch set 4 11/16/20, 15:26

    Unresolved

    That sentences isn't right.
  5. TYPO3com voted on patch set 4 V +1 11/16/20, 15:37 Completed build in 13m 24s on Mon, 16 Nov, 03:37 PM Test Summary: 73623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7359

  6. Alexander Schnitzler commented on patch set 4 11/16/20, 17:08

    This change is ready for review.
  7. Georg Ringer commented on patch set 4 11/16/20, 17:58

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:21

    11.0

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:39

    should be linked with #87264 with the :issue:`87264` I guess

    Backend.php:173

    those removals could be handled by the extensionScanner + mention it in an rst file

    DataMapper.php:633

    extensionScanner + rst would still be nice

    Session.php:79

    extensionScanner + rst would still be nice

    Typo3DbBackend.php:281

    extensionScanner + rst would still be nice
  8. Alexander Schnitzler uploaded patch set 5 12/05/20, 12:39

  9. Alexander Schnitzler commented on patch set 5 12/05/20, 12:39

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:21 Reply

    Done

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:39 Reply

    Done

    Backend.php:173 Reply

    Done

    DataMapper.php:633 Reply

    Done

    Session.php:79 Reply

    Done

    Typo3DbBackend.php:281 Reply

    Done
  10. TYPO3com voted on patch set 5 V +1 12/05/20, 12:48 Completed build in 09m 19s on Sat, 5 Dec, 12:48 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7828

  11. Markus Klein commented on patch set 5 12/05/20, 14:32

    Deprecation-89938-RemoveDeadCodeFromExtbasePersistence.rst:4 Unresolved

    docs should be past tense (contrary to commit messages). "Removed dead code..."
  12. Markus Klein commented on patch set 6 12/05/20, 14:34

    Published edit on patch set 5.
  13. Markus Klein voted on patch set 6 CR +1 12/05/20, 14:35

  14. TYPO3com voted on patch set 6 V -1 12/05/20, 14:44 Completed build in 09m 35s on Sat, 5 Dec, 02:44 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7830

  15. Markus Klein commented on patch set 7 12/05/20, 15:04

    Published edit on patch set 6.
  16. TYPO3com voted on patch set 7 V +1 12/05/20, 15:12 Completed build in 08m 46s on Sat, 5 Dec, 03:12 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7832

  17. Georg Ringer commented on patch set 7 12/05/20, 21:10

    isn't this more a breaking change (Which is fine) but should also marked as such?
  18. Alexander Schnitzler commented on patch set 7 12/06/20, 07:43

    Reply

    Still don't think so because we only remove code from internal classes and interfaces. Removing methods from interfaces expresses that methods in implementations aren't called by the framework. It doesn't break userland code.
  19. Benni Mack commented on patch set 7 12/08/20, 11:50

    I think we should go ahead and remove these not-used methods. In addition @markusklein maybe we can then implement the support for "LanguageAspect" or "Context" in general for QuerySettings?
  20. Alexander Schnitzler uploaded patch set 8 12/08/20, 14:46

  21. TYPO3com voted on patch set 8 V +1 12/08/20, 14:56 Completed build in 09m 56s on Tue, 8 Dec, 02:56 PM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7966

  22. Benni Mack voted on patch set 8 V +1 CR +1 12/08/20, 15:13

  23. Markus Klein commented on patch set 8 V +1 CR +1 12/21/20, 19:00

    Reply

    Yes, this is on my prio list, but won't be done within this year.
  24. Benni Mack voted on patch set 8 V +2 CR +2 12/22/20, 07:20

  25. Benni Mack merged patch set 9 12/22/20, 07:20