Review main Merged

62621[BUGFIX] Fix return value in command site:list

Georg Ringer CR +2 V +2 Easy +2 −1 updated 12/16/19, 06:13

Commit message

Return 0 instead of null.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1621

  1. Georg Ringer uploaded patch set 1 12/13/19, 14:06

  2. Georg Ringer commented on patch set 1 12/13/19, 14:07

    This change is ready for review.
  3. Timo Webler commented on patch set 1 12/13/19, 14:11

    SiteListCommand.php:93 Unresolved

    Also here a return value is needed
  4. Alexander Schnitzler commented on patch set 1 12/13/19, 14:15

    Can you explain why a 0 is needed instead of null? I mean in the commit message, because the api allows to return both but I guess you have a reason to return explicitly 0 here.
  5. TYPO3com voted on patch set 1 V +1 12/13/19, 14:15 Completed build in 08m 43s on Fri, 13 Dec, 02:15 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39394

  6. Timo Webler commented on patch set 1 12/13/19, 14:40

    > Patch Set 1: > > Can you explain why a 0 is needed instead of null? > I mean in the commit message, because the api allows to return both but I guess you have a reason to return explicitly 0 here. Changelog: https://github.com/symfony/console/blob/master/CHANGELOG.md > removed support for returning null from Command::execute(), return 0 instead
  7. Benni Mack voted on patch set 1 V +1 CR +1 12/13/19, 14:47

  8. Stefan Neufeind voted on patch set 1 CR +1 12/13/19, 15:30

  9. Stefan Neufeind voted on patch set 1 CR 0 12/13/19, 15:35

  10. Stefan Neufeind commented on patch set 2 12/13/19, 15:35

    Published edit on patch set 1.
  11. TYPO3com voted on patch set 2 V -1 12/13/19, 15:35 Completed build in 17s on Fri, 13 Dec, 03:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39399

  12. Stefan Neufeind commented on patch set 3 12/13/19, 15:36

    Published edit on patch set 2.
  13. TYPO3com voted on patch set 3 V -1 12/13/19, 15:45 Completed build in 08m 01s on Fri, 13 Dec, 03:45 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39400

  14. Alexander Schnitzler voted on patch set 3 V +1 CR +1 12/13/19, 15:52

  15. TYPO3com voted on patch set 3 V +1 12/13/19, 15:53 Completed build in 24m 44s on Fri, 13 Dec, 03:53 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39400

  16. Daniel Goerz commented on patch set 3 12/15/19, 17:34

    Unresolved

    Remove?
  17. Daniel Goerz updated the commit message in patch set 4 12/15/19, 17:35

  18. Daniel Goerz voted on patch set 4 V +1 CR +1 12/15/19, 17:35

  19. TYPO3com voted on patch set 4 V +1 12/15/19, 17:42 Completed build in 07m 33s on Sun, 15 Dec, 05:42 PM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39441

  20. Susi Moog voted on patch set 4 V +2 CR +2 12/16/19, 06:13

  21. Susi Moog merged patch set 5 12/16/19, 06:13