Review main Merged

62624[TASK] Move constant declaration to class constants

Benni Mack CR +2 V +2 Hard +198 −64 updated 01/10/20, 14:07

Commit message

Using Class constants instead of constants that are defined during
runtime has the following benefits:

- Naming can be made more consistent (and separated)
- Speeding up requests where the constants are not needed
- Benefit from Opcaching of class loading instead of dynamic runtime definition
- Testing framework has less "bootstrap" to do

This affects the following constants:
- TYPO3_copyright_year
- TYPO3_URL_GENERAL
- TYPO3_URL_LICENSE
- TYPO3_URL_EXCEPTION
- TYPO3_URL_DONATE
- TYPO3_URL_WIKI_OPCODECACHE

The constants are now deprecated.

In addition, the "Typo3Copyright" class is now called "TYPO3Information".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 20

Review log 1322

  1. Benni Mack uploaded patch set 1 12/13/19, 15:25

  2. TYPO3com voted on patch set 1 V -1 12/13/19, 15:33 Completed build in 08m 30s on Fri, 13 Dec, 03:33 PM Test Summary: 132 of 69164 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39397

  3. Benni Mack uploaded patch set 2 12/16/19, 21:39

  4. TYPO3com voted on patch set 2 V -1 12/16/19, 21:48 Completed build in 08m 03s on Mon, 16 Dec, 09:48 PM Test Summary: 132 of 68964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39467

  5. Anja Leichsenring uploaded patch set 3 12/18/19, 14:37

  6. TYPO3com voted on patch set 3 V -1 12/18/19, 14:37 Completed build in 13s on Wed, 18 Dec, 02:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39513

  7. Anja Leichsenring uploaded patch set 4 12/18/19, 14:40

  8. TYPO3com voted on patch set 4 V -1 12/18/19, 14:49 Completed build in 08m 55s on Wed, 18 Dec, 02:49 PM Test Summary: 68847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39514

  9. TYPO3com voted on patch set 4 V +1 12/18/19, 14:57 Completed build in 26m 25s on Wed, 18 Dec, 02:57 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39514

  10. Benni Mack uploaded patch set 5 01/09/20, 12:13

  11. TYPO3com voted on patch set 5 V -1 01/09/20, 12:40 Completed build in 18m 31s on Thu, 9 Jan, 12:40 PM Test Summary: 5 of 69629 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39766

  12. Benni Mack updated the commit message in patch set 6 01/09/20, 14:28

  13. TYPO3com voted on patch set 6 V +1 01/09/20, 14:37 Completed build in 08m 35s on Thu, 9 Jan, 02:37 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39767

  14. Georg Ringer commented on patch set 6 01/09/20, 19:21

    what about renaming Typo3Copyright to Typo3Information?

    Typo3Copyright.php:25 Unresolved

    again, IMO either the const or the getter
  15. Benni Mack uploaded patch set 7 01/10/20, 08:16

  16. TYPO3com voted on patch set 7 V -1 01/10/20, 08:24 Completed build in 07m 46s on Fri, 10 Jan, 08:24 AM Test Summary: 24511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39779

  17. Benni Mack uploaded patch set 8 01/10/20, 09:00

  18. Benni Mack commented on patch set 8 01/10/20, 09:00

    Thanks, Georg for your remarks. The patch is now ready to review
  19. TYPO3com voted on patch set 8 V +1 01/10/20, 09:26 Completed build in 26m 11s on Fri, 10 Jan, 09:26 AM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39780

  20. Anja Leichsenring voted on patch set 8 V +1 CR +1 01/10/20, 11:16

  21. Georg Ringer voted on patch set 8 V +2 CR +2 01/10/20, 14:07

  22. Georg Ringer merged patch set 9 01/10/20, 14:07