62624[TASK] Move constant declaration to class constants
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Georg Ringer +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 20
- typo3/sysext/about/Classes/Controller/AboutController.php+11 −10
- typo3/sysext/backend/Classes/Controller/HelpController.php+8 −7
- typo3/sysext/backend/Classes/Controller/LoginController.php+6 −6
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+2 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −3
- typo3/sysext/core/Classes/Controller/ErrorPageController.php+3 −2
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php+26 −10
- typo3/sysext/core/Classes/Error/DebugExceptionHandler.php+3 −1
- typo3/sysext/core/Classes/Information/Typo3Information.phprenamed+33 −12
- typo3/sysext/core/Documentation/Changelog/10.2/Deprecation-89756-BackendUtilityTYPO3_copyRightNotice.rst+2 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89866-Global-TYPO3-information-related-constants.rstnew+53 −0
- typo3/sysext/core/Tests/Unit/Error/ProductionExceptionHandlerTest.php+2 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+2 −5
- typo3/sysext/frontend/Tests/Unit/Controller/ErrorControllerTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+2 −0
- typo3/sysext/frontend/Tests/Unit/Middleware/PageArgumentValidatorTest.php+4 −2
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+2 −1
- typo3/sysext/install/Classes/SystemEnvironment/SetupCheck.php+2 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ConstantMatcher.php+30 −0
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+2 −1
Review log 1322
-
Benni Mack uploaded patch set 1 12/13/19, 15:25
-
TYPO3com voted on patch set 1 V -1 12/13/19, 15:33 Completed build in 08m 30s on Fri, 13 Dec, 03:33 PM Test Summary: 132 of 69164 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39397
-
Benni Mack uploaded patch set 2 12/16/19, 21:39
-
TYPO3com voted on patch set 2 V -1 12/16/19, 21:48 Completed build in 08m 03s on Mon, 16 Dec, 09:48 PM Test Summary: 132 of 68964 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39467
-
Anja Leichsenring uploaded patch set 3 12/18/19, 14:37
-
TYPO3com voted on patch set 3 V -1 12/18/19, 14:37 Completed build in 13s on Wed, 18 Dec, 02:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39513
-
Anja Leichsenring uploaded patch set 4 12/18/19, 14:40
-
TYPO3com voted on patch set 4 V -1 12/18/19, 14:49 Completed build in 08m 55s on Wed, 18 Dec, 02:49 PM Test Summary: 68847 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39514
-
TYPO3com voted on patch set 4 V +1 12/18/19, 14:57 Completed build in 26m 25s on Wed, 18 Dec, 02:57 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39514
-
Benni Mack uploaded patch set 5 01/09/20, 12:13
-
TYPO3com voted on patch set 5 V -1 01/09/20, 12:40 Completed build in 18m 31s on Thu, 9 Jan, 12:40 PM Test Summary: 5 of 69629 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39766
-
Benni Mack updated the commit message in patch set 6 01/09/20, 14:28
-
TYPO3com voted on patch set 6 V +1 01/09/20, 14:37 Completed build in 08m 35s on Thu, 9 Jan, 02:37 PM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39767
-
Georg Ringer commented on patch set 6 01/09/20, 19:21
what about renaming Typo3Copyright to Typo3Information?Typo3Copyright.php:25Unresolvedagain, IMO either the const or the getter -
Benni Mack uploaded patch set 7 01/10/20, 08:16
-
TYPO3com voted on patch set 7 V -1 01/10/20, 08:24 Completed build in 07m 46s on Fri, 10 Jan, 08:24 AM Test Summary: 24511 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39779
-
Benni Mack uploaded patch set 8 01/10/20, 09:00
-
Benni Mack commented on patch set 8 01/10/20, 09:00
Thanks, Georg for your remarks. The patch is now ready to review -
TYPO3com voted on patch set 8 V +1 01/10/20, 09:26 Completed build in 26m 11s on Fri, 10 Jan, 09:26 AM Test Summary: 69179 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39780
-
Anja Leichsenring voted on patch set 8 V +1 CR +1 01/10/20, 11:16
-
Georg Ringer voted on patch set 8 V +2 CR +2 01/10/20, 14:07
-
Georg Ringer merged patch set 9 01/10/20, 14:07