Review main Merged

62627[TASK] Simplify checks on Import about allowed filenames

Benni Mack CR +2 V +2 Easy +2 −2 updated 12/27/19, 20:29

Commit message

In TYPO3 v10, BasicFileUtility is not used by DataHandler anymore,
and never initialized with other file permissions than "allow
any file ending", which is why the simple check on the fileDenyPattern
can be used directly in Import functionality.

The next patch would then allow to clean up BasicFileUtility
where the methods which belong to "internal_type=file" are not in use
anymore.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Benni Mack uploaded patch set 1 12/13/19, 18:22

  2. TYPO3com voted on patch set 1 V -1 12/13/19, 18:30 Completed build in 07m 52s on Fri, 13 Dec, 06:30 PM Test Summary: 68446 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39406

  3. Benni Mack rebased onto patch set 2 12/13/19, 18:48

  4. TYPO3com voted on patch set 2 V +1 12/13/19, 18:59 Completed build in 10m 33s on Fri, 13 Dec, 06:59 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39409

  5. Georg Ringer voted on patch set 2 CR +1 12/13/19, 19:05

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 12/18/19, 11:17

  7. Susi Moog voted on patch set 2 V +2 CR +2 12/20/19, 07:20

  8. Susi Moog merged patch set 3 12/20/19, 07:20

  9. Oliver Hader voted on patch set 3 CR +1 12/27/19, 20:29