Review main Merged

62628[TASK] Thin out SystemEnvironmentBuilder

Benni Mack CR +2 V +2 Normal +40 −98 updated 12/15/19, 14:53

Commit message

This a pre-patch to clean up the functionality of the SystemEnvironmentBuilder,
which was originally introduced as part of the Bootstrap logic in 6.0.

However, a few cross-concerns can be cut in TYPO3 v10:
- Calling the deprecated GeneralUtility::presetApplicationContext() is not
needed anymore, as it can be populated on-demand when the deprecated
GeneralUtility::getApplicationContext() method is called via Environment API.
This way, the ApplicationContext initialization can be put directly in the
Environment API initialization call.
- The static "isFunctionDisabled" method with a nasty runtime cache is only
used in one place in backend, so does not belong to "building system environment",
and is therefore removed.
- The now unused "exitWithMessage" protected method is removed,
removing a dependency to the HttpUtility class.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack uploaded patch set 1 12/13/19, 18:29

  2. TYPO3com voted on patch set 1 V -1 12/13/19, 18:30 Completed build in 19s on Fri, 13 Dec, 06:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39407

  3. Benni Mack uploaded patch set 2 12/13/19, 18:44

  4. TYPO3com voted on patch set 2 V +1 12/13/19, 18:53 Completed build in 08m 41s on Fri, 13 Dec, 06:53 PM Test Summary: 68712 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39408

  5. Georg Ringer voted on patch set 2 CR +1 12/13/19, 19:04

  6. Alexander Schnitzler commented on patch set 2 12/14/19, 13:56

    SystemEnvironmentBuilder.php:273 Unresolved

    There is no if needed here Just return the result of the expression.
  7. Daniel Goerz uploaded patch set 3 12/15/19, 13:15

  8. TYPO3com voted on patch set 3 V +1 12/15/19, 13:22 Completed build in 07m 12s on Sun, 15 Dec, 01:22 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39431

  9. Daniel Goerz voted on patch set 3 V +1 CR +1 12/15/19, 13:25

  10. Susi Moog voted on patch set 3 V +2 CR +2 12/15/19, 14:53

  11. Susi Moog merged patch set 4 12/15/19, 14:53