Review main Merged

62629[BUGFIX] Respect line breaks in media's description

Georg Ringer CR +2 V +2 Easy +3 −3 updated 01/12/20, 12:40

Commit message

As the description is using a textarea element in the backend,
editors can add a multi-line text.
The line breaks should be shown in the frontend as well by using
f:format.nl2br.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Guido Schmechel +1
    • Markus Klein +1
    • Jan Stockfisch +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Guido Schmechel +1
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1821

  1. Georg Ringer uploaded patch set 1 12/13/19, 19:26

  2. Georg Ringer commented on patch set 1 12/13/19, 19:26

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 12/13/19, 19:34 Completed build in 07m 39s on Fri, 13 Dec, 07:34 PM Test Summary: 68421 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39410

  4. TYPO3com voted on patch set 1 V +1 12/13/19, 19:49 Completed build in 30m 29s on Fri, 13 Dec, 07:49 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39410

  5. Oli Bartsch commented on patch set 1 12/13/19, 20:31

    In general this patch seems really valid. But this seems to have the opportunity to unexpectly break someones frontend output. We should at least provide an Important rst for this change to inform integrators/developers about this change so they can take further actions if necessary.
  6. Ghanshyam Bhava voted on patch set 1 V +1 CR +1 12/14/19, 13:26

  7. Andreas Kienast voted on patch set 1 CR +1 12/14/19, 13:56

  8. Markus Klein commented on patch set 1 12/14/19, 20:46

    Yes, I agree with the change, but it can indeed break layouts. I'm really undecided. Maybe an Important rst is sufficient. Others would even say this is a breaking change.
  9. Guido Schmechel commented on patch set 1 12/14/19, 21:59

    I would actually only change it in the master. If you want to, you can easily overwrite the output with fluid.
  10. Daniel Goerz commented on patch set 1 CR -1 12/15/19, 13:08

    I don't think we should change output behavior in v9 with a BUGFIX.
  11. Georg Ringer commented on patch set 1 12/16/19, 08:06

    9.5 is the current LTS version and only current stable version. if we don't fix that for 9.5 we can stop any bugfix. every bugfix changes behaviour.
  12. Susi Moog commented on patch set 1 12/16/19, 08:10

    We once agreed to not change rendering at all in released stable versions. If people need that change in 9.5, overwriting the templates themselves is easy and recommended. Now changing it for those that rely on the default behaviour _is_ imho breaking.
  13. Daniel Goerz commented on patch set 1 12/16/19, 08:13

    > Patch Set 1: > > 9.5 is the current LTS version and only current stable version. if we don't fix that for 9.5 we can stop any bugfix. every bugfix changes behaviour. The important word is not "behaviour" but "output" :)
  14. Georg Ringer updated the commit message in patch set 2 12/16/19, 09:24

  15. TYPO3com voted on patch set 2 V +1 12/16/19, 09:33 Completed build in 08m 04s on Mon, 16 Dec, 09:33 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39448

  16. Jan Stockfisch voted on patch set 2 CR +1 12/16/19, 18:14

  17. Susi Moog voted on patch set 2 CR +1 12/17/19, 13:21

  18. Guido Schmechel voted on patch set 2 V +1 CR +1 12/24/19, 10:40

  19. Markus Klein voted on patch set 2 V +1 CR +1 01/12/20, 10:46

  20. Daniel Goerz voted on patch set 2 V +2 CR +2 01/12/20, 12:40

  21. Daniel Goerz merged patch set 3 01/12/20, 12:40