Review main Merged

62630[BUGFIX] Directly resolve links to pages of type External URL

Benni Mack CR +2 V +2 Easy +29 −12 updated 01/13/20, 21:44

Commit message

HMENU provides a way to directly create the external link
if a page is of type "External URLs" but typolink does not
resulting in

a) more bandwidth / hits for TYPO3 when using typolink
b) different results / expectations.

The patch makes typolink handle external URLs like HMENU.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 710

  1. Benni Mack uploaded patch set 1 12/13/19, 21:39

  2. TYPO3com voted on patch set 1 V +1 12/13/19, 21:46 Completed build in 07m 22s on Fri, 13 Dec, 09:46 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39414

  3. Benni Mack uploaded patch set 2 12/23/19, 22:37

  4. TYPO3com voted on patch set 2 V -1 12/23/19, 22:45 Completed build in 08m 05s on Mon, 23 Dec, 10:45 PM Test Summary: 11 of 69581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39564

  5. TYPO3com voted on patch set 2 V +1 12/24/19, 08:16 Completed build in 9h 47m 43s on Tue, 24 Dec, 08:16 AM Test Summary: 69129 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39564

  6. Jörg Bösche voted on patch set 2 CR +1 01/13/20, 14:12

  7. Susi Moog voted on patch set 2 CR +1 01/13/20, 17:58

  8. Susi Moog voted on patch set 2 V +1 01/13/20, 21:25

  9. Daniel Goerz voted on patch set 2 V +2 CR +2 01/13/20, 21:44

  10. Daniel Goerz merged patch set 3 01/13/20, 21:44