Review main Merged

62631[TASK] Migrate linkvalidator results from serializable to json storage

Benni Mack CR +2 V +2 Easy +14 −12 updated 01/09/20, 07:35

Commit message

LinkAnalyzer now stores the response as JSON instead of PHP serialize.

A fallback mechanism when unpacking uses unserialize() as fallback
to keep records in the database.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jonas Eberle +1
    • Sybille Peters +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jonas Eberle +1
    • Sybille Peters +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1011

  1. Benni Mack uploaded patch set 1 12/13/19, 22:14

  2. TYPO3com voted on patch set 1 V +1 12/13/19, 22:22 Completed build in 08m 19s on Fri, 13 Dec, 10:22 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39415

  3. Oliver Klee commented on patch set 1 12/13/19, 22:55

    LinkAnalyzer.php:247

    Do we need to encode unicode characters? Otherwise, we could pass the JSON_UNESCAPED_UNICODE flag, making the JSON smaller and more human-readable.

    LinkAnalyzer.php:254 Unresolved

    Ditto.
  4. Sybille Peters voted on patch set 1 V +1 CR +1 12/14/19, 07:48

  5. Benni Mack commented on patch set 1 12/16/19, 11:10

    LinkAnalyzer.php:247 Reply

    yeah, we have labels (translateable) in there...
  6. Oliver Klee commented on patch set 1 12/16/19, 11:15

    LinkAnalyzer.php:247 Reply

    I think my question was ambiguous. I'll rephrase: AFAIK, unescaped unicode characters work fine in JSON. Do we rely on those being escaped, or would the characters being there unescaped work (which would make the JSON shorter and more human-readable)?
  7. Oliver Hader voted on patch set 1 CR +1 12/16/19, 11:20

  8. Jonas Eberle commented on patch set 1 V +1 CR +1 12/23/19, 13:32

    LinkAnalyzer.php:247 Reply Unresolved

    It would work both ways. Currently this option is used in 4 places in the core while there are around 100 where it could most probably be also applied. So maybe that's something for a cleanup round throughout the core?
  9. Sybille Peters commented on patch set 1 01/08/20, 12:56

    Can we get this merged? Existing data in tx_linkvalidator_link (which is serialized) will still work. I see only advantages. The risk of breaking something is very minimal. (IMHO, the localized error message should not be saved to the tx_linkvalidator_link DB in the first place. From the stored metadata (error type, exception etc.) an error message must be created for the current Backend user anyway - when the report is shown. Everything that is necessary to create the localized error message is in the array. But that is not the scope of this patch. That is handled in a separate patch.)
  10. Georg Ringer voted on patch set 1 V +2 CR +2 01/09/20, 07:35

  11. Georg Ringer merged patch set 2 01/09/20, 07:35