62632[BUGFIX] Remove exclude field for transOrigPointerFields
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Georg Ringer +1
-
Verified V +2 Done
- Benni Mack +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 2
Files 31
- typo3/sysext/core/Classes/Migrations/TcaMigration.php2+24 −0
- typo3/sysext/core/Configuration/TCA/pages.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_category.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_collection.php+0 −1
- typo3/sysext/core/Configuration/TCA/sys_file_collection.php+0 −1
- typo3/sysext/core/Documentation/Changelog/master/Important-89672-TransOrigPointerFieldIsNotLongerAllowedToBeExcluded.rstnew+21 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1ncsv_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_1nff_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_hotel_offer_rel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnasym_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_hotel_offer_rel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnattr_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_hotel.php+0 −1
Show 11 more files
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_offer.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnmmasym_price.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel.php+0 −1
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Configuration/TCA/tx_irretutorial_mnsym_hotel_rel.php+0 −1
- typo3/sysext/core/Tests/Unit/Migrations/TcaMigrationTest.php+82 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_blog.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_info.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_person.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_post.php+0 −1
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Configuration/TCA/tx_blogexample_domain_model_tag.php+0 −1
- typo3/sysext/frontend/Configuration/TCA/tt_content.php+0 −1
Review log 1115
-
Oli Bartsch uploaded patch set 1 12/13/19, 22:19
-
TYPO3com voted on patch set 1 V +1 12/13/19, 22:29 Completed build in 09m 28s on Fri, 13 Dec, 10:29 PM Test Summary: 68720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39417
-
Markus Klein commented on patch set 1 CR -1 12/16/19, 10:36
-
Oli Bartsch commented on patch set 1 12/17/19, 08:50
TcaMigration.php:288Reply UnresolvedHi, currently we check if `transOrigPointerField` is set and if so, we check if the corresponding column configuration for the field (e.g. l18n_parent) has the key `exclude` no matter if it is set to true or false. -
Benni Mack updated the commit message in patch set 2 12/23/19, 20:50
-
TYPO3com voted on patch set 2 V -1 12/23/19, 20:58 Completed build in 07m 23s on Mon, 23 Dec, 08:58 PM Test Summary: 24 of 59468 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39558
-
Benni Mack commented on patch set 2 12/31/19, 13:20
I consider this the appropriate way and to only put it in master. -
Benni Mack rebased onto patch set 3 01/30/20, 13:19
-
TYPO3com voted on patch set 3 V +1 01/30/20, 13:31 Completed build in 12m 32s on Thu, 30 Jan, 01:31 PM Test Summary: 70846 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40361
-
Oli Bartsch uploaded patch set 4 01/31/20, 20:40
-
TYPO3com voted on patch set 4 V +1 01/31/20, 20:56 Completed build in 15m 20s on Fri, 31 Jan, 08:56 PM Test Summary: 71188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40446
-
Benni Mack voted on patch set 4 CR +1 01/31/20, 21:55
-
Georg Ringer voted on patch set 4 V +1 CR +1 02/14/20, 19:57
-
Benni Mack voted on patch set 4 V +2 CR +2 02/14/20, 20:25
-
Benni Mack merged patch set 5 02/14/20, 20:25
TcaMigration.php:288