Review main Merged

62632[BUGFIX] Remove exclude field for transOrigPointerFields

Oli Bartsch CR +2 V +2 Normal +127 −28 updated 02/14/20, 20:25

Commit message

transOrigPointerFields can not longer be excluded as this leads
to inconsistent data stored in the database if a non-admin
user created a localization by not having the permission to edit
the transOrigPointerField.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 31

Show 11 more files

Review log 1115

  1. Oli Bartsch uploaded patch set 1 12/13/19, 22:19

  2. TYPO3com voted on patch set 1 V +1 12/13/19, 22:29 Completed build in 09m 28s on Fri, 13 Dec, 10:29 PM Test Summary: 68720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39417

  3. Markus Klein commented on patch set 1 CR -1 12/16/19, 10:36

    TcaMigration.php:288

    isset is the wrong check here. I often set exclude=>false, which would trigger here then. !empty() is the best option I would say
  4. Oli Bartsch commented on patch set 1 12/17/19, 08:50

    TcaMigration.php:288 Reply Unresolved

    Hi, currently we check if `transOrigPointerField` is set and if so, we check if the corresponding column configuration for the field (e.g. l18n_parent) has the key `exclude` no matter if it is set to true or false.
  5. Benni Mack updated the commit message in patch set 2 12/23/19, 20:50

  6. TYPO3com voted on patch set 2 V -1 12/23/19, 20:58 Completed build in 07m 23s on Mon, 23 Dec, 08:58 PM Test Summary: 24 of 59468 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39558

  7. Benni Mack commented on patch set 2 12/31/19, 13:20

    I consider this the appropriate way and to only put it in master.
  8. Benni Mack rebased onto patch set 3 01/30/20, 13:19

  9. TYPO3com voted on patch set 3 V +1 01/30/20, 13:31 Completed build in 12m 32s on Thu, 30 Jan, 01:31 PM Test Summary: 70846 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40361

  10. Oli Bartsch uploaded patch set 4 01/31/20, 20:40

  11. TYPO3com voted on patch set 4 V +1 01/31/20, 20:56 Completed build in 15m 20s on Fri, 31 Jan, 08:56 PM Test Summary: 71188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40446

  12. Benni Mack voted on patch set 4 CR +1 01/31/20, 21:55

  13. Georg Ringer voted on patch set 4 V +1 CR +1 02/14/20, 19:57

  14. Benni Mack voted on patch set 4 V +2 CR +2 02/14/20, 20:25

  15. Benni Mack merged patch set 5 02/14/20, 20:25