62633[TASK] Move target to general tab for pages of type External URL
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Riccardo De Contardi +1
-
Verified V +2 Done
- Daniel Goerz +2
- Riccardo De Contardi +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 45
-
Benni Mack uploaded patch set 1 12/13/19, 22:21
-
TYPO3com voted on patch set 1 V +1 12/13/19, 22:31 Completed build in 08m 04s on Fri, 13 Dec, 10:31 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39418
-
Riccardo De Contardi commented on patch set 1 V +1 CR +1 12/13/19, 23:14
my thoughts on this change: CONS: less interface consistency PROS: for doktype external url the target attribute can be considered more "important" than the other doktypes, so it belongs to the General tab, while it is more acceptable for the other doktypes that it stays more "hidden". -
Daniel Goerz voted on patch set 1 V +2 CR +2 12/15/19, 11:19
-
Daniel Goerz merged patch set 2 12/15/19, 11:19