Review main Merged

62639[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner"

Andreas Kienast CR +2 V +2 Normal +92 −86 updated 12/19/19, 17:33

Commit message

The "Broken Extension Scanner" has some flaws that are fixed with this
patch:

- Only one request is sent to scan all ext_localconf.php /
  ext_tables.php files, each
- ext_tables.php is only scanned if ext_localconf.php was successful,
  since those are dependent
- Protected extensions (mandatory to the system) cannot get uninstalled
- After uninstalling an extension all caches are cleared

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Susi Moog +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 913

  1. Andreas Kienast uploaded patch set 1 12/14/19, 13:04

  2. TYPO3com voted on patch set 1 V +1 12/14/19, 13:15 Completed build in 10m 18s on Sat, 14 Dec, 01:15 PM Test Summary: 68714 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39423

  3. Anja Leichsenring updated the commit message in patch set 2 12/16/19, 13:46

  4. TYPO3com voted on patch set 2 V -1 12/16/19, 13:54 Completed build in 07m 36s on Mon, 16 Dec, 01:54 PM Test Summary: 68767 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39456

  5. Andreas Kienast uploaded patch set 3 12/16/19, 13:57

  6. TYPO3com voted on patch set 3 V +1 12/16/19, 14:04 Completed build in 07m 39s on Mon, 16 Dec, 02:04 PM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39457

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 12/16/19, 14:07

  8. Jan Stockfisch commented on patch set 3 CR -1 12/16/19, 18:56

    ExtensionCompatTester.ts:26 Unresolved

    "protected" is a reserved keyword. Maybe a different name would be better?
  9. Andreas Kienast uploaded patch set 4 12/19/19, 06:51

  10. TYPO3com voted on patch set 4 V +1 12/19/19, 07:06 Completed build in 13m 34s on Thu, 19 Dec, 07:06 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39522

  11. Anja Leichsenring voted on patch set 4 V +1 CR +1 12/19/19, 08:38

  12. Susi Moog voted on patch set 4 V +2 CR +2 12/19/19, 17:33

  13. Susi Moog merged patch set 5 12/19/19, 17:33