Review main Merged

62648[TASK] Remove redundancies in install tool ext conf template

Claus Due CR +2 V +2 Normal +28 −83 updated 12/17/19, 15:21

Commit message

This patch:

1. Removes a redundant usage of a "NoSpace" VH and
   the associated namespace import since there are no
   other usages.
2. Deletes the VH class since it is not used elsewhere.
3. Removes an always-true and therefore redundant "if"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jan Stockfisch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Claus Due uploaded patch set 1 12/16/19, 10:55

  2. TYPO3com voted on patch set 1 V +1 12/16/19, 11:03 Completed build in 08m 16s on Mon, 16 Dec, 11:03 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39451

  3. Jan Stockfisch voted on patch set 1 V +1 CR +1 12/17/19, 07:26

  4. Benni Mack voted on patch set 1 V +2 CR +2 12/17/19, 15:21

  5. Benni Mack merged patch set 2 12/17/19, 15:21