62650[TASK] Remove dead code in ExtensionConfiguration class
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- Oliver Klee +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1724
-
Claus Due uploaded patch set 1 12/16/19, 11:01
-
Simon Gilli voted on patch set 1 CR +1 12/16/19, 11:05
-
TYPO3com voted on patch set 1 V -1 12/16/19, 11:11 Completed build in 09m 27s on Mon, 16 Dec, 11:11 AM Test Summary: 3 of 69227 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39452
-
Simon Gilli commented on patch set 1 CR -1 12/16/19, 12:13
This change is breaking!!! -
Claus Due commented on patch set 1 12/16/19, 12:14
Reply
I'm not sure that's the case, IIRC we allow changing @internal methods' signatures as non-breaking. At least, this has happened to me quite a few times in minor updates. -
Simon Gilli commented on patch set 1 CR +1 12/16/19, 12:27
Reply
You're right, didn't see the @internal -
TYPO3com commented on patch set 1 12/16/19, 12:41 Completed build in 1h 48m 56s on Mon, 16 Dec, 12:41 PM Test Summary: 3 of 69227 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39452
-
TYPO3com commented on patch set 1 01/18/20, 16:56 Completed build in 12m 27s on Sat, 18 Jan, 04:56 PM Test Summary: 3 of 70895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40072
-
TYPO3com commented on patch set 1 01/18/20, 17:45 Completed build in 1h 14m 05s on Sat, 18 Jan, 05:45 PM Test Summary: 3 of 70895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40072
-
TYPO3com commented on patch set 1 02/22/20, 19:02 Completed build in 28m 10s on Sat, 22 Feb, 07:02 PM Test Summary: 3 of 72067 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-502
-
Daniel Goerz uploaded patch set 2 10/09/20, 14:21
-
Daniel Goerz voted on patch set 2 CR +1 10/09/20, 14:22
-
TYPO3com voted on patch set 2 V +1 10/09/20, 14:39 Completed build in 16m 49s on Fri, 9 Oct, 02:38 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6406
-
Oliver Klee voted on patch set 2 CR +1 10/09/20, 14:48
-
Markus Klein commented on patch set 2 V -1 CR -1 10/09/20, 15:15
We use this feature all the time in our site setups! -
Markus Klein commented on patch set 2 10/09/20, 15:15
e.g. $extensionConfiguration->set('news', 'tagPid', 2); -
Markus Klein commented on patch set 2 V +1 CR +1 10/09/20, 15:19
Okay, I found a workaround. Fine with me, let it go -
Daniel Goerz uploaded patch set 3 10/09/20, 15:25
-
Daniel Goerz voted on patch set 3 V +1 CR +1 10/09/20, 15:27
-
Oli Bartsch voted on patch set 3 V +1 CR +1 10/09/20, 15:30
-
TYPO3com voted on patch set 3 V +1 10/09/20, 15:39 Completed build in 13m 42s on Fri, 9 Oct, 03:38 PM Test Summary: 73764 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6412
-
Oliver Klee voted on patch set 3 CR +1 10/09/20, 15:46
-
Daniel Goerz voted on patch set 3 V +2 CR +2 10/09/20, 15:50
-
Daniel Goerz merged patch set 4 10/09/20, 15:50