Review main Merged

62651[BUGFIX] Ensure correct return values in Workspace middleware

Benni Mack CR +2 V +2 Easy +4 −3 updated 12/16/19, 14:41

Commit message

When setting config.disablePreviewNotification = 1 in workspaces
context, the preview middleware returns "null", although the method
signature says it always requires a string return value.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Oliver Klee +1
    • Achim Fritz +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 12/16/19, 11:21

  2. TYPO3com voted on patch set 1 V +1 12/16/19, 11:28 Completed build in 07m 18s on Mon, 16 Dec, 11:28 AM Test Summary: 68774 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39453

  3. Daniel Goerz voted on patch set 1 V +1 CR +1 12/16/19, 12:48

  4. Achim Fritz voted on patch set 1 V +1 CR +1 12/16/19, 13:56

  5. Oliver Klee voted on patch set 1 CR +1 12/16/19, 14:35

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 12/16/19, 14:41

  7. Andreas Kienast merged patch set 2 12/16/19, 14:41