Review 9.5 Merged

62656[BUGFIX] Ensure correct return values in Workspace middleware

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 12/16/19, 15:04

Commit message

When setting config.disablePreviewNotification = 1 in workspaces
context, the preview middleware returns "null", although the method
signature says it always requires a string return value.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 12/16/19, 14:41

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/16/19, 14:51 Completed build in 10m 19s on Mon, 16 Dec, 02:51 PM Test Summary: 71990 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1719

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/16/19, 15:04

  4. Benni Mack merged patch set 2 12/16/19, 15:04