Review 9.5 Merged

62659[TASK] Fix closure comparison in test

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 12/18/19, 08:00

Commit message

ExactValueMatching of Closures in Prophecy may
result in Comparison Failures causing the test
to fail in newer PHPUnit Versions. Instead of
an exact match of that closure, a type comparison
is enough - as calling the closure is tested via
following assertions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 12/18/19, 07:49

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/18/19, 07:59 Completed build in 09m 34s on Wed, 18 Dec, 07:59 AM Test Summary: 72577 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1739

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 12/18/19, 08:00

  4. Andreas Kienast merged patch set 2 12/18/19, 08:00