Review 9.5 Merged

62660[BUGFIX] Use correct implode(string, array) syntax

Georg Ringer CR +2 V +2 Easy +8 −8 updated 12/18/19, 16:03

Commit message

The usage of implode(array, string) has been marked as
deprecated by PHP and triggers PHP Deprecation warnings
by using PHP 7.4.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 46

  1. Georg Ringer commented on patch set 1 12/18/19, 15:36

    Cherry Picked from branch master.
  2. Anja Leichsenring updated the commit message in patch set 2 12/18/19, 15:41

  3. TYPO3com voted on patch set 1 V +1 12/18/19, 15:56 Completed build in 12m 43s on Wed, 18 Dec, 03:56 PM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1741

  4. TYPO3com voted on patch set 2 V +1 12/18/19, 16:02 Completed build in 18m 24s on Wed, 18 Dec, 04:02 PM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1742

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 12/18/19, 16:03

  6. Anja Leichsenring merged patch set 3 12/18/19, 16:03