Review 9.5 Merged

62665[BUGFIX] Fix various misbehaviors in "Broken Extension Scanner"

Susi Moog CR +2 V +2 Normal +84 −69 updated 01/13/20, 07:40

Commit message

The "Broken Extension Scanner" has some flaws that are fixed with this
patch:

- Only one request is sent to scan all ext_localconf.php /
  ext_tables.php files, each
- ext_tables.php is only scanned if ext_localconf.php was successful,
  since those are dependent
- Protected extensions (mandatory to the system) cannot get uninstalled
- After uninstalling an extension all caches are cleared

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Susi Moog commented on patch set 1 12/19/19, 17:34

    Cherry Picked from branch master. The following files contain Git conflicts: * Build/Sources/TypeScript/install/Resources/Public/TypeScript/Module/Upgrade/ExtensionCompatTester.ts * typo3/sysext/install/Classes/Controller/UpgradeController.php * typo3/sysext/install/Resources/Public/JavaScript/Module/Upgrade/ExtensionCompatTester.js
  2. TYPO3com voted on patch set 1 V -1 12/19/19, 17:34 Completed build in 12s on Thu, 19 Dec, 05:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1745

  3. Andreas Kienast uploaded patch set 2 12/20/19, 12:33

  4. TYPO3com voted on patch set 2 V +1 12/20/19, 12:42 Completed build in 09m 20s on Fri, 20 Dec, 12:42 PM Test Summary: 72576 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1747

  5. Susi Moog commented on patch set 2 12/21/19, 15:09

    This change is ready for review.
  6. Andreas Kienast voted on patch set 2 V +2 CR +2 01/13/20, 07:40

  7. Andreas Kienast merged patch set 3 01/13/20, 07:40