Review TYPO3_8-7 Merged

62666[BUGFIX] Include .htaccess file in extension packages

Susi Moog CR +2 V +2 Easy +1 −1 updated 12/27/19, 18:12

Commit message

Adopt the excludeForPackaging to include also .htaccess files in
extension downloads of extension manager.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Oliver Klee +1
    • Jonas Eberle +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Jonas Eberle +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 912

  1. Susi Moog commented on patch set 1 12/20/19, 07:21

    Cherry Picked from branch 9.5. The following files contain Git conflicts: * typo3/sysext/core/Configuration/DefaultConfiguration.php
  2. TYPO3com voted on patch set 1 V -1 12/20/19, 07:22 Completed build in 12s on Fri, 20 Dec, 07:21 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3807

  3. Susi Moog commented on patch set 2 12/20/19, 07:23

    Published edit on patch set 1.
  4. Susi Moog commented on patch set 2 12/20/19, 07:23

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V -1 12/20/19, 07:33 Completed build in 10m 23s on Fri, 20 Dec, 07:33 AM Test Summary: 101390 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3808

  6. TYPO3com voted on patch set 2 V +1 12/20/19, 07:48 Completed build in 35m 40s on Fri, 20 Dec, 07:48 AM Test Summary: 101751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3808

  7. Jonas Eberle voted on patch set 2 V +1 CR +1 12/23/19, 09:40

  8. Jonas Eberle commented on patch set 2 12/23/19, 09:44

    I think the Regex could be improved (It still matches something like "build_node_modules") but it's probably not worth the energy. This fixes the forge bug.
  9. Oliver Klee voted on patch set 2 CR +1 12/23/19, 10:58

  10. Jonas Eberle commented on patch set 2 12/23/19, 13:06

    Sorry, I didn't notice that this is the backport already.
  11. Oliver Hader voted on patch set 2 V +2 CR +2 12/27/19, 18:12

  12. Oliver Hader merged patch set 3 12/27/19, 18:12