Review 9.5 Abandoned

62667[BUGFIX] Avoid showing telephone element for route link browser

Benni Mack CR 0 V 0 Easy +2 −2 updated 12/26/19, 13:13

Commit message

Affects following site configuration aspects in site management module:
* page based error handling source field in link popup
* URI base static source field in link popup

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 6871

Show 4446 earlier messages
  1. Benni Mack commented on patch set 1 12/23/19, 12:05

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 12/23/19, 12:12 Completed build in 07m 24s on Mon, 23 Dec, 12:12 PM Test Summary: 12567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1748

  3. TYPO3com commented on patch set 1 12/23/19, 12:31 Completed build in 33m 15s on Mon, 23 Dec, 12:31 PM Test Summary: 39937 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1748

  4. Oliver Hader commented on patch set 1 CR -1 12/23/19, 14:20

    Not sure, but I think telephone was not added to 9.5, correct?
  5. Oliver Hader voted on patch set 1 CR -2 12/23/19, 14:20

  6. Oliver Hader commented on patch set 1 12/23/19, 14:21

  7. Benni Mack commented on patch set 1 12/23/19, 22:00

    hey
  8. Benni Mack commented on patch set 1 12/23/19, 22:00

    so
  9. Benni Mack commented on patch set 1 12/23/19, 22:00

    should
  10. Benni Mack commented on patch set 1 12/23/19, 22:00

    we
  11. Benni Mack commented on patch set 1 V -1 CR -1 12/23/19, 22:00

    abandon
  12. Benni Mack commented on patch set 1 V 0 CR 0 12/23/19, 22:01

    this
  13. Benni Mack commented on patch set 1 CR -1 12/23/19, 22:01

    back
  14. Benni Mack commented on patch set 1 12/23/19, 22:01

    port?
  15. Benni Mack voted on patch set 1 CR 0 12/23/19, 22:01

  16. Benni Mack commented on patch set 1 12/23/19, 22:01

    you
  17. Benni Mack commented on patch set 1 12/23/19, 22:01

    can
  18. Benni Mack commented on patch set 1 12/23/19, 22:01

    decide
  19. Benni Mack commented on patch set 1 12/23/19, 22:01

    just
  20. Benni Mack commented on patch set 1 12/23/19, 22:01

    let
  21. Benni Mack commented on patch set 1 12/23/19, 22:01

    me
  22. Benni Mack commented on patch set 1 12/23/19, 22:01

    know
  23. Oliver Hader voted on patch set 1 CR -1 12/24/19, 09:47

  24. Oliver Hader voted on patch set 1 CR 0 12/24/19, 09:47

  25. Oliver Hader voted on patch set 1 CR +1 12/24/19, 09:47

  26. Oliver Hader voted on patch set 1 CR 0 12/24/19, 09:47

  27. Oliver Hader commented on patch set 1 12/24/19, 09:47

    hm, ok..
  28. Oliver Hader commented on patch set 1 12/24/19, 09:47

    I'd opt for abandoning
  29. Oliver Hader commented on patch set 1 12/24/19, 09:48

    Does not look like this has been in place
  30. Oliver Hader commented on patch set 1 12/24/19, 09:48

    ... for the 9.5 branch
  31. Oliver Hader commented on patch set 1 12/24/19, 09:48

    So, I'd abandon
  32. Oliver Hader voted on patch set 1 CR +1 12/24/19, 09:48

  33. Oliver Hader voted on patch set 1 CR -1 12/24/19, 09:48

  34. Oliver Hader commented on patch set 1 12/24/19, 09:48

    Abandoned since `tel:` feature not available in 9.5 branch
  35. Oliver Hader abandoned the change 12/24/19, 09:49

    Abandoned since `tel:` feature not available in 9.5 branch
  36. Benni Mack restored the change 12/24/19, 12:41

  37. Benni Mack updated the commit message in patch set 2 12/24/19, 12:41

  38. Benni Mack commented on patch set 2 12/24/19, 12:42

    I
  39. Benni Mack commented on patch set 2 12/24/19, 12:42

    wonder
  40. Benni Mack commented on patch set 2 12/24/19, 12:42

    if
  41. Benni Mack commented on patch set 2 12/24/19, 12:42

    we
  42. Benni Mack commented on patch set 2 12/24/19, 12:42

    should
  43. Benni Mack commented on patch set 2 12/24/19, 12:42

    still
  44. Benni Mack commented on patch set 2 12/24/19, 12:42

    include
  45. Benni Mack commented on patch set 2 12/24/19, 12:42

    it
  46. Benni Mack commented on patch set 2 12/24/19, 12:42

    there
  1. Benni Mack commented on patch set 2 12/24/19, 12:42

    are
  2. Benni Mack commented on patch set 2 12/24/19, 12:42

    extensions
  3. Benni Mack commented on patch set 2 12/24/19, 12:42

    in
  4. Benni Mack commented on patch set 2 12/24/19, 12:42

    9.5
  5. Benni Mack commented on patch set 2 12/24/19, 12:43

    that
  6. Benni Mack commented on patch set 2 12/24/19, 12:43

    implement
  7. Benni Mack commented on patch set 2 12/24/19, 12:43

    this
  8. Benni Mack commented on patch set 2 12/24/19, 12:43

    functionality
  9. Benni Mack commented on patch set 2 12/24/19, 12:43

    what
  10. Benni Mack commented on patch set 2 12/24/19, 12:43

    do
  11. Benni Mack commented on patch set 2 12/24/19, 12:43

    you
  12. Benni Mack commented on patch set 2 12/24/19, 12:43

    think
  13. Benni Mack voted on patch set 2 CR -1 12/24/19, 12:43

  14. Benni Mack voted on patch set 2 CR +1 12/24/19, 12:43

  15. Benni Mack voted on patch set 2 V -1 12/24/19, 12:43

  16. TYPO3com voted on patch set 2 V -1 12/24/19, 12:51 Completed build in 09m 25s on Tue, 24 Dec, 12:51 PM Test Summary: 71919 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1749

  17. Oliver Hader commented on patch set 2 CR +1 12/24/19, 15:26

    Not sure
  18. Oliver Hader commented on patch set 2 CR -1 12/24/19, 15:26

    Argh... "probably not"
  19. Georg Ringer commented on patch set 2 12/25/19, 08:07

    merry
  20. Georg Ringer commented on patch set 2 12/25/19, 08:07

    christmas
  21. Georg Ringer commented on patch set 2 12/25/19, 08:07

    would not backport that, also not in the happy new year
  22. Benni Mack abandoned the change 12/25/19, 15:09

    abandoned in 2019
  23. Benni Mack commented on patch set 2 12/25/19, 15:09

    agreed
  24. Benni Mack commented on patch set 2 12/25/19, 15:09

    Georg
  25. Oliver Hader commented on patch set 2 12/26/19, 13:13

    Cool