Review 9.5 Merged

62669[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field

Benni Mack CR +2 V +2 Easy +1 −0 updated 12/27/19, 20:19

Commit message

For upgrading from an old versions where EXT:realurl was used
the PopulatePagesSlugs upgradeWizard is in place.
It now also respects the tx_realurl_pathsegment field in generatorOptions.

The workflow is now, that it takes the page:tx_realurl_pathsegment field
and if empty falls back to page:title.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 47

  1. Benni Mack commented on patch set 1 12/27/19, 15:22

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 12/27/19, 15:34 Completed build in 11m 27s on Fri, 27 Dec, 03:34 PM Test Summary: 466 of 72841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1756

  3. TYPO3com commented on patch set 1 12/27/19, 15:54 Completed build in 43m 27s on Fri, 27 Dec, 03:54 PM Test Summary: 763 of 73178 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1756

  4. TYPO3com voted on patch set 1 V +1 12/27/19, 16:09 Completed build in 1h 30m 33s on Fri, 27 Dec, 04:09 PM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1756

  5. Benni Mack voted on patch set 1 V +2 CR +2 12/27/19, 16:13

  6. Benni Mack merged patch set 2 12/27/19, 16:13

  7. Oliver Hader voted on patch set 2 CR +1 12/27/19, 20:19