Review TYPO3_4-5 Merged

6267[BUGFIX] Check for rsaauth being usable

Xavier Perseguers CR +2 V +2 Normal +54 −11 updated 06/03/13, 20:49

Commit message

The Extension Manager shows the results of some checks in the
Configuration section of the extension "saltedpasswords", whether
"rsaauth" is loaded and whether it is enabled.

However, it lacks a check for "rsaauth" being really able to work.
If "rsaauth" fails, tell the user that OpenSSL extension is not available
or not working correctly.

Review

  • Code review CR +2
    • Xavier Perseguers +2
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 5

  1. Markus Klein commented on patch set 1 11/01/11, 19:54

    (1 inline comment) Fails.

    class.tx_saltedpasswords_emconfhelper.php:287

    That's not working. The class has not been loaded before. (No autoloading for rsaauth in 4.5)

    class.tx_saltedpasswords_emconfhelper.php:288

    Also getBackend is a static function, so this would suffice: $backend = tx_rsaauth_backendfactory::getBackend();
  2. Xavier Perseguers commented on patch set 1 V 0 11/01/11, 19:54

    by team member; Looks good to me, approved Backported from master
  3. Xavier Perseguers merged patch set 1 11/01/11, 19:54

  4. Mr. Jenkins commented on patch set 1 11/01/11, 19:54

  5. Markus Klein commented on patch set 1 11/01/11, 19:54

    (1 inline comment) Just a tiny remark.