Review 9.5 Merged

62670[BUGFIX] Test failure due to erroneous usage of uniqueId() function

Benni Mack CR +2 V +2 Easy +1 −1 updated 12/27/19, 15:45

Commit message

The function in testing-framework provides a string that is target to be
used e.g. for HTML tags, but the BackendUserAuthenticationTest uses it
to produce a random userId, which needs to be an integer.
If the randomly produced string contains not only numbers, the cast
operation converts the uid to 0 and therefor prevents a DB query
from execution. This prevention results in a not consumed mock object,
which in turn causes a integration test failure.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 12/27/19, 15:28

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 12/27/19, 15:41 Completed build in 11m 21s on Fri, 27 Dec, 03:41 PM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1757

  3. Benni Mack voted on patch set 1 V +2 CR +2 12/27/19, 15:45

  4. Benni Mack merged patch set 2 12/27/19, 15:45