Review 10.2 Merged

62693[TASK] Streamline frontend user password recovery process

Oliver Hader CR +2 V +2 Easy +8 −2 updated 12/17/19, 09:12

Commit message

The ext:felogin recovery process is using a non-typesafe comparison
which might be exploited with a probability of 0.000000294% and is
storing the recovery token as plain MD5-hash in database.

In order to streamline the process non-typesafe comparison is using
PHP's hash_equals() method; for keeping backward compatibility just
HMAC-SHA1 is applied to the recovery token in database.

Since exploitations to this scenario are very unlikely (for a 50%
chance an attacker would have to trigger the creation of around
170 million recovery requests) it is not handled with a security
workflow - but using the public workflow.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 1

Review log 3

  1. Oliver Hader uploaded patch set 1 12/17/19, 08:27

  2. Oliver Hader voted on patch set 1 V +2 CR +2 12/17/19, 09:12

  3. Oliver Hader merged patch set 2 12/17/19, 09:12