Review TYPO3_8-7 Merged

62699[SECURITY] Avoid directory traversal on archive extraction

Oliver Hader CR +2 V +2 Hard +352 −96 updated 12/17/19, 10:07

Commit message

The Extension Manager and Language Pack Manager receive Zip archives as
input from foreign sources and extract them on the disk. However, the
previous approach is considered insecure as the target directory is not
checked per file and directory traversal was possible.

This patch adds a new service class that handles the extraction of Zip
archives via PHP's internal ZipArchive class, which can handle such
cases on its own.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 8

Review log 34

  1. Oliver Hader uploaded patch set 1 12/17/19, 09:50

  2. Oliver Hader commented on patch set 1 V +2 CR +2 12/17/19, 09:50

    Auto-approved
  3. Oliver Hader merged patch set 2 12/17/19, 09:50

  4. TYPO3com voted on patch set 1 V +1 12/17/19, 10:07 Completed build in 14m 27s on Tue, 17 Dec, 10:07 AM Test Summary: 101306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3796