Review 9.5 Merged

62705[SECURITY] XSS in file list through file extension

Oliver Hader CR +2 V +2 Easy +1 −1 updated 12/17/19, 10:16

Commit message

FAL currently filters invalid characters from file names stored by its
API. However, this sanitization took no effect when the file was placed
by e.g. uploads via FTP, which doesn't trigger FAL.

This patch adds a missing `htmlspecialchars` call when the file
extension is rendered and could not be sanitized before due to mentioned
circumstances.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2

Issues 1

Files 1

Review log 34

  1. Oliver Hader uploaded patch set 1 12/17/19, 09:51

  2. Oliver Hader commented on patch set 1 V +2 CR +2 12/17/19, 09:51

    Auto-approved
  3. Oliver Hader merged patch set 2 12/17/19, 09:51

  4. TYPO3com voted on patch set 1 V +1 12/17/19, 10:16 Completed build in 20m 19s on Tue, 17 Dec, 10:16 AM Test Summary: 72056 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1728