62735[FEATURE] Introduce status report for ExceptionHandler
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Tobi Kretschmann +1
-
Verified V +2 Done
- Daniel Goerz +2
- Tobi Kretschmann +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 810
-
Susi Moog uploaded patch set 1 12/17/19, 16:42
-
Susi Moog updated the commit message in patch set 2 12/17/19, 16:43
-
TYPO3com voted on patch set 1 V +1 12/17/19, 16:53 Completed build in 10m 57s on Tue, 17 Dec, 04:53 PM Test Summary: 69294 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39487
-
TYPO3com voted on patch set 2 V +1 12/17/19, 16:56 Completed build in 12m 12s on Tue, 17 Dec, 04:56 PM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39488
-
Alexander Schnitzler commented on patch set 2 12/20/19, 10:25
It's slightly offtopic but shouldn't we consider using the native value of error_reporting instead of our replica in globals and display a warning in the install tool as well, if error_reporting is set to 1, no matter the context? Same goes for display_startup_errors. If and how we mingle that setting with the configuration of exception and error handlers is a different topic but at the moment it's quite confusing that native values aren't used. Same goes for error_reporting but that's also another topic. -
Alexander Schnitzler commented on patch set 2 12/22/19, 12:35
SecurityStatus.php:249I had some time to review and I think this first condition is such an edge case that I would not mix it with a quite common case (conditions on 2nd line). If someone sets the DebugExceptionHandler as production exception handler, then we should tell her/him that this is a bad practice and very risky because neither $GLOBALS['TYPO3_CONF_VARS']['SYS']['displayErrors'] nor ini_set('display_errors', '1') has any effect any more.SecurityStatus.php:250We could get rid of the global here and check ini_get('display_errors') instead. That's currently failsafe as we always override the ini value during bootstrap and it's future proof in case we want to get rid of the global altogether. -
Susi Moog commented on patch set 2 01/16/20, 09:47
SecurityStatus.php:249Reply UnresolvedI'd expect to see that as error in the report, too - which is all this is currently about.SecurityStatus.php:250Reply UnresolvedI would do that in another change and not mix both ways currently. let's get rid of the global in one step. -
Tobi Kretschmann voted on patch set 2 V +1 CR +1 01/16/20, 10:56
-
Daniel Goerz voted on patch set 2 V +2 CR +2 01/16/20, 11:34
-
Daniel Goerz merged patch set 3 01/16/20, 11:35