Review main Merged

62737[TASK] Fix closure comparison in test

Susi Moog CR +2 V +2 Easy +2 −2 updated 12/18/19, 07:49

Commit message

ExactValueMatching of Closures in Prophecy may
result in Comparison Failures causing the test
to fail in newer PHPUnit Versions. Instead of
an exact match of that closure, a type comparison
is enough - as calling the closure is tested via
following assertions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jan Stockfisch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jan Stockfisch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Susi Moog uploaded patch set 1 12/18/19, 07:27

  2. TYPO3com voted on patch set 1 V +1 12/18/19, 07:35 Completed build in 07m 52s on Wed, 18 Dec, 07:35 AM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39497

  3. Susi Moog commented on patch set 1 12/18/19, 07:37

    Base for the error is https://github.com/phpspec/prophecy/blob/master/src/Prophecy/Comparator/ClosureComparator.php (which means closures are never equal) - newer phpunit versions properly handle that comparison failure.
  4. Susi Moog updated the commit message in patch set 2 12/18/19, 07:39

  5. Susi Moog commented on patch set 2 12/18/19, 07:39

    This change is ready for review.
  6. Andreas Kienast voted on patch set 2 V +1 CR +1 12/18/19, 07:40

  7. Jan Stockfisch voted on patch set 2 V +1 CR +1 12/18/19, 07:40

  8. TYPO3com voted on patch set 2 V +1 12/18/19, 07:46 Completed build in 07m 03s on Wed, 18 Dec, 07:46 AM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39498

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 12/18/19, 07:49

  10. Andreas Kienast merged patch set 3 12/18/19, 07:49