62737[TASK] Fix closure comparison in test
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Jan Stockfisch +1
-
Verified V +2 Done
- Andreas Kienast +2
- Jan Stockfisch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 810
-
Susi Moog uploaded patch set 1 12/18/19, 07:27
-
TYPO3com voted on patch set 1 V +1 12/18/19, 07:35 Completed build in 07m 52s on Wed, 18 Dec, 07:35 AM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39497
-
Susi Moog commented on patch set 1 12/18/19, 07:37
Base for the error is https://github.com/phpspec/prophecy/blob/master/src/Prophecy/Comparator/ClosureComparator.php (which means closures are never equal) - newer phpunit versions properly handle that comparison failure. -
Susi Moog updated the commit message in patch set 2 12/18/19, 07:39
-
Susi Moog commented on patch set 2 12/18/19, 07:39
This change is ready for review. -
Andreas Kienast voted on patch set 2 V +1 CR +1 12/18/19, 07:40
-
Jan Stockfisch voted on patch set 2 V +1 CR +1 12/18/19, 07:40
-
TYPO3com voted on patch set 2 V +1 12/18/19, 07:46 Completed build in 07m 03s on Wed, 18 Dec, 07:46 AM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39498
-
Andreas Kienast voted on patch set 2 V +2 CR +2 12/18/19, 07:49
-
Andreas Kienast merged patch set 3 12/18/19, 07:49