Review main Merged

62738[TASK] Update codeception and phpunit to latest versions

Anja Leichsenring CR +2 V +2 Easy +16 −12 updated 12/27/19, 20:24

Commit message

Updating codeception (3.2.1) and phpunit (8.5.0)
to latest versions allows for further updating other dependencies
TYPO3 is using.

Used command:
	composer update codeception/codeception
	composer update phpunit/phpunit

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Anja Leichsenring uploaded patch set 1 12/18/19, 10:41

  2. TYPO3com voted on patch set 1 V +1 12/18/19, 10:56 Completed build in 14m 49s on Wed, 18 Dec, 10:56 AM Test Summary: 69296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39500

  3. Benni Mack commented on patch set 1 12/19/19, 12:31

    This also updates symfony packages, which is nice, but actually an interesting side-effect. Usually I update the symfony/* and doctrine/* packages separately to detect any issues with these dependencies. I'll create a separate patch for this.
  4. Benni Mack uploaded patch set 2 12/19/19, 12:37

  5. TYPO3com voted on patch set 2 V +1 12/19/19, 12:46 Completed build in 09m 01s on Thu, 19 Dec, 12:46 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39531

  6. Benni Mack voted on patch set 2 V +2 CR +2 12/20/19, 08:14

  7. Benni Mack merged patch set 3 12/20/19, 08:14

  8. Oliver Hader voted on patch set 3 CR +1 12/27/19, 20:24