Review main Merged

62741[BUGFIX] Use correct implode(string, array) syntax

Anja Leichsenring CR +2 V +2 Easy +8 −8 updated 12/18/19, 15:40

Commit message

The usage of implode(array, string) has been marked as
deprecated by PHP and triggers PHP Deprecation warnings
by using PHP 7.4.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klösges +1
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1215

  1. Anja Leichsenring uploaded patch set 1 12/18/19, 14:01

  2. TYPO3com voted on patch set 1 V +1 12/18/19, 14:15 Completed build in 13m 24s on Wed, 18 Dec, 02:15 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39505

  3. Andreas Kienast commented on patch set 1 CR -1 12/18/19, 14:15

    TimeTracker.php:472 Unresolved

    This was a hr before
  4. Andreas Kienast commented on patch set 2 12/18/19, 14:15

    Published edit on patch set 1.
  5. Andreas Kienast voted on patch set 2 V +1 CR +1 12/18/19, 14:28

  6. TYPO3com voted on patch set 2 V -1 12/18/19, 14:32 Completed build in 16m 59s on Wed, 18 Dec, 02:32 PM Test Summary: 7 of 69579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39508

  7. TYPO3com voted on patch set 2 V +1 12/18/19, 15:02 Completed build in 1h 04m 08s on Wed, 18 Dec, 03:02 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39508

  8. Benni Mack commented on patch set 2 12/18/19, 15:10

    shouldn't we also fix that for 8.7?
  9. Markus Klein commented on patch set 2 12/18/19, 15:13

    > Patch Set 2: > > shouldn't we also fix that for 8.7? Would be nice.
  10. Anja Leichsenring commented on patch set 2 12/18/19, 15:28

    > Patch Set 2: > > > Patch Set 2: > > > > shouldn't we also fix that for 8.7? > > Would be nice. sure thing, but I did not find a single occurrence in 8.7.
  11. Markus Klösges voted on patch set 2 CR +1 12/18/19, 15:35

  12. Oliver Klee voted on patch set 2 CR +1 12/18/19, 15:35

  13. Georg Ringer voted on patch set 2 V +2 CR +2 12/18/19, 15:36

  14. Georg Ringer merged patch set 3 12/18/19, 15:36

  15. Anja Leichsenring commented on patch set 3 12/18/19, 15:40

    > Patch Set 2: > > > Patch Set 2: > > > > > Patch Set 2: > > > > > > shouldn't we also fix that for 8.7? > > > > Would be nice. > > sure thing, but I did not find a single occurrence in 8.7. okay, my bad, I had the inspection running with PHP 7.0 on 8.7. Of course there is also some wrong usage.