62743[FEATURE] Provide feature flag for new translation server's export
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Chris Müller +1
- Markus Klein +1
- Jan Stockfisch +1
- Jörg Bösche +1
-
Verified V +2 Done
- Benni Mack +2
- Chris Müller +1
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 5
- typo3/sysext/core/Configuration/DefaultConfiguration.php+1 −0
- typo3/sysext/core/Configuration/DefaultConfigurationDescription.yaml+3 −0
- typo3/sysext/core/Configuration/FactoryConfiguration.php+2 −1
- typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-89556-FeatureFlagBetaTranslationServer.rstnew+24 −0
- typo3/sysext/install/Classes/Service/LanguagePackService.php+11 −1
Review log 1516
-
Georg Ringer uploaded patch set 1 12/18/19, 15:34
-
Georg Ringer commented on patch set 1 12/18/19, 15:35
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 12/18/19, 15:48 Completed build in 13m 34s on Wed, 18 Dec, 03:48 PM Test Summary: 72578 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1740
-
Markus Klein voted on patch set 1 CR +1 12/19/19, 07:03
-
Jan Stockfisch commented on patch set 1 CR -1 12/19/19, 07:25
Code looks finde to me. But a feature for 9.5? -
Jan Stockfisch voted on patch set 1 CR +1 12/19/19, 08:41
-
Jörg Bösche voted on patch set 1 CR +1 12/19/19, 09:13
-
Chris Müller commented on patch set 1 CR +1 12/27/19, 18:08
After testing: Only core extensions can be fetched from the new translation server for now. For example, the codehighlight extension, which is translated on Crowdin, cannot be fetched (404) for German. Is it not available yet or should it exist on the new translation server? -
Markus Klein commented on patch set 1 12/27/19, 18:54
> Patch Set 1: Code-Review+1 > > After testing: Only core extensions can be fetched from the new translation server for now. For example, the codehighlight extension, which is translated on Crowdin, cannot be fetched (404) for German. Is it not available yet or should it exist on the new translation server? According to https://localize.typo3.org/fileadmin/ter/status.html the Translation Status is 100% for DE. And the latest build on the server I see is: Dec 27 15:04 codehiglight-l10n-de.zip not sure what the problem might be, but didn't test yet -
Chris Müller commented on patch set 1 12/27/19, 19:05
> Patch Set 1: > > > Patch Set 1: Code-Review+1 > > > > After testing: Only core extensions can be fetched from the new translation server for now. For example, the codehighlight extension, which is translated on Crowdin, cannot be fetched (404) for German. Is it not available yet or should it exist on the new translation server? > > According to https://localize.typo3.org/fileadmin/ter/status.html the Translation Status is 100% for DE. > And the latest build on the server I see is: > Dec 27 15:04 codehiglight-l10n-de.zip > > not sure what the problem might be, but didn't test yet The built URL is https://localize.typo3.org/fileadmin/ter/c/o/codehighlight-l10n/codehighlight-l10n-de.zip which throws a 404, whereas https://localize.typo3.org/fileadmin/ter/b/e/beuser-l10n/beuser-l10n-de.v9.zip for the core succeeds. -
Chris Müller commented on patch set 1 12/27/19, 19:09
> The built URL is https://localize.typo3.org/fileadmin/ter/c/o/codehighlight-l10n/codehighlight-l10n-de.zip which throws a 404, whereas https://localize.typo3.org/fileadmin/ter/b/e/beuser-l10n/beuser-l10n-de.v9.zip for the core succeeds. Okay, there is a typo, a missing "h" on the server, also on the status page. On Crowdin it is spelled correctly, will test another extension. -
Chris Müller commented on patch set 1 V +1 12/27/19, 19:13
Okay, tt_address worked. So my +1 also for Verified :-) -
Markus Klein commented on patch set 1 12/27/19, 22:12
Seems to be fixed now: server has correct one now too Dec 27 23:05 codehighlight-l10n -
Markus Klein voted on patch set 1 V +1 12/27/19, 22:13
-
Benni Mack voted on patch set 1 V +2 CR +2 01/09/20, 07:21
-
Benni Mack merged patch set 2 01/09/20, 07:21