Review main Merged

62747[TASK] Use new translation server

Georg Ringer CR +2 V +2 Easy +35 −11 updated 01/12/20, 12:46

Commit message

Remove the feature switch `betaTranslationServer` and use the new
translation server by default.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1320

  1. Georg Ringer uploaded patch set 1 12/18/19, 21:19

  2. TYPO3com voted on patch set 1 V -1 12/18/19, 21:19 Completed build in 13s on Wed, 18 Dec, 09:19 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39518

  3. Georg Ringer commented on patch set 1 12/18/19, 21:19

    This change is ready for review.
  4. Georg Ringer uploaded patch set 2 12/18/19, 21:19

  5. TYPO3com voted on patch set 2 V +1 12/18/19, 21:28 Completed build in 07m 59s on Wed, 18 Dec, 09:28 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39519

  6. Markus Klein commented on patch set 2 12/19/19, 07:02

    Important-89992-UseNewTranslationServer.rst:14

    being

    Important-89992-UseNewTranslationServer.rst:18

    Project, which

    LanguagePackService.php:255 Unresolved

    could be the beta-url as well, that's not covered below, right?
  7. Benni Mack commented on patch set 2 12/31/19, 13:24

    LanguagePackService.php:64

    let's just name it "LANGUAGE_PACK_URL" and do that. "current" is very ambiguous.
  8. Georg Ringer uploaded patch set 3 01/08/20, 20:16

  9. TYPO3com voted on patch set 3 V -1 01/08/20, 20:24 Completed build in 08m 38s on Wed, 8 Jan, 08:24 PM Test Summary: 8 of 69647 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39760

  10. TYPO3com voted on patch set 3 V +1 01/10/20, 09:43 Completed build in 13h 35m 46s on Fri, 10 Jan, 09:43 AM Test Summary: 69197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39760

  11. Benni Mack voted on patch set 3 V +1 CR +1 01/10/20, 09:45

  12. Markus Klein commented on patch set 3 CR -1 01/10/20, 09:54

    Important-89992-UseNewTranslationServer.rst:14 Reply

    Done

    Important-89992-UseNewTranslationServer.rst:18 Reply

    Done

    LanguagePackService.php:64 Reply

    Done

    LanguagePackService.php:260 Unresolved

    This could hold the "beta" URL as well, in that case it is not rewritten to the new url!
  13. Markus Klein uploaded patch set 4 01/12/20, 10:43

  14. Markus Klein uploaded patch set 5 01/12/20, 10:44

  15. Markus Klein voted on patch set 5 V +1 CR +1 01/12/20, 10:45

  16. TYPO3com voted on patch set 4 V -1 01/12/20, 11:00 Completed build in 16m 28s on Sun, 12 Jan, 11:00 AM Test Summary: 7 of 69641 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39801

  17. TYPO3com voted on patch set 5 V -1 01/12/20, 11:10 Completed build in 16m 58s on Sun, 12 Jan, 11:10 AM Test Summary: 172 of 69076 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39802

  18. TYPO3com voted on patch set 5 V +1 01/12/20, 12:15 Completed build in 1h 39m 05s on Sun, 12 Jan, 12:15 PM Test Summary: 69191 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39802

  19. Daniel Goerz voted on patch set 5 V +2 CR +2 01/12/20, 12:46

  20. Daniel Goerz merged patch set 6 01/12/20, 12:46