Review main Merged

62748[BUGFIX] PopulatePagesSlugs should respect tx_realurl_pathsegment field

anonymized-52878 CR +2 V +2 Easy +1 −0 updated 12/27/19, 15:22

Commit message

For upgrading from an old versions where EXT:realurl was used
the PopulatePagesSlugs upgradeWizard is in place.
It now also respects the tx_realurl_pathsegment field in generatorOptions.

The workflow is now, that it takes the page:tx_realurl_pathsegment field
and if empty falls back to page:title.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1014

  1. anonymized-52878 uploaded patch set 1 12/19/19, 08:31

  2. TYPO3com voted on patch set 1 V +1 12/19/19, 08:40 Completed build in 08m 21s on Thu, 19 Dec, 08:40 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39523

  3. anonymized-52878 updated the commit message in patch set 2 12/19/19, 08:41

  4. TYPO3com voted on patch set 2 V +1 12/19/19, 08:49 Completed build in 08m 25s on Thu, 19 Dec, 08:49 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39524

  5. Jörg Bösche voted on patch set 2 CR +1 12/19/19, 09:11

  6. Oli Bartsch commented on patch set 2 V -1 12/19/19, 09:51

    Could you please add proper linebreaks to the commit message. I would also suggest to add a proper description in the form of a sentence. Something like: "For upgrading from an old version where tx_realurl was used the PopulatePagesSlugs upgradeWizard is in place. It now also respects the tx_realurl_pathsegment field in generatorOptions."
  7. anonymized-52878 updated the commit message in patch set 3 12/19/19, 10:12

  8. anonymized-52878 commented on patch set 3 12/19/19, 10:13

    > Patch Set 2: Verified-1 > > Could you please add proper linebreaks to the commit message. > > I would also suggest to add a proper description in the form of a sentence. > > Something like: > "For upgrading from an old version where tx_realurl was used > the PopulatePagesSlugs upgradeWizard is in place. It now > also respects the tx_realurl_pathsegment field in generatorOptions." I update the commit message - sorry can you advice me what you mean with "proper linebreaks"
  9. TYPO3com voted on patch set 3 V +1 12/19/19, 10:21 Completed build in 08m 09s on Thu, 19 Dec, 10:21 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39526

  10. anonymized-52878 updated the commit message in patch set 4 12/19/19, 10:56

  11. TYPO3com voted on patch set 4 V +1 12/19/19, 11:04 Completed build in 07m 41s on Thu, 19 Dec, 11:04 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39529

  12. Guido Schmechel voted on patch set 4 V +1 CR +1 12/24/19, 10:41

  13. Benni Mack voted on patch set 4 V +2 CR +2 12/27/19, 15:22

  14. Benni Mack merged patch set 5 12/27/19, 15:22