62750[FEATURE] Option to copy page access settings from parent page
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 3
Review log 5269
Show 3444 earlier messages
-
Rudy Gnodde uploaded patch set 1 12/19/19, 13:01
-
TYPO3com voted on patch set 1 V +1 12/19/19, 13:09 Completed build in 07m 02s on Thu, 19 Dec, 01:09 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39532
-
Mathias Brodala commented on patch set 1 CR -1 12/19/19, 13:38
There must be a feature RST for this: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html -
Rudy Gnodde uploaded patch set 2 12/19/19, 14:15
-
TYPO3com voted on patch set 2 V +1 12/19/19, 14:22 Completed build in 07m 12s on Thu, 19 Dec, 02:22 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39533
-
Benni Mack commented on patch set 2 12/27/19, 15:06
Hi Rudy, let's get that one in first so we can easily add tests to this feature then: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62763 -
Rudy Gnodde uploaded patch set 3 12/31/19, 11:25
-
Rudy Gnodde uploaded patch set 4 12/31/19, 11:29
-
TYPO3com voted on patch set 3 V +1 12/31/19, 11:34 Completed build in 08m 25s on Tue, 31 Dec, 11:34 AM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39674
-
TYPO3com voted on patch set 4 V +1 12/31/19, 11:37 Completed build in 07m 47s on Tue, 31 Dec, 11:37 AM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39675
-
Rudy Gnodde rebased onto patch set 5 12/31/19, 12:13
-
TYPO3com voted on patch set 5 V +1 12/31/19, 12:20 Completed build in 06m 57s on Tue, 31 Dec, 12:20 PM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39679
-
Benni Mack commented on patch set 4 12/31/19, 12:23
Now that I see the code very clearly in the code, I wonder the following things that we should cover (with tests and RST): - What's the behavior if I copy a page (incl. subpages) from "Parent Page A" to "Parent Page B" - what permissions should be applied? - What's the behavior of that in a workspaces (because the SQL query does not cover this at all)? -
Rudy Gnodde commented on patch set 5 12/31/19, 12:37
> Patch Set 4: > > Now that I see the code very clearly in the code, I wonder the following things that we should cover (with tests and RST): > - What's the behavior if I copy a page (incl. subpages) from "Parent Page A" to "Parent Page B" - what permissions should be applied? When copying the behavior should be the same as it would be with a non-inherent, non-empty setting. It will set them as if they're new pages, so inherit from the page you're copying into. If this needs to be different it should be changed for the existing functionality as well. > - What's the behavior of that in a workspaces (because the SQL query does not cover this at all)? I never use workspaces, so didn't test this. I'll see if I can test this now. -
Rudy Gnodde commented on patch set 5 12/31/19, 12:44
> > - What's the behavior of that in a workspaces (because the SQL query does not cover this at all)? > > I never use workspaces, so didn't test this. I'll see if I can test this now. I tested this and the inherited settings seem to always be taken from the live workspace. As I never work with workspaces, I'm not sure how to fix this though. Do you have any hints or examples? -
Rudy Gnodde uploaded patch set 6 01/03/20, 12:00
-
Rudy Gnodde uploaded patch set 7 01/03/20, 12:01
-
TYPO3com voted on patch set 6 V +1 01/03/20, 12:08 Completed build in 08m 35s on Fri, 3 Jan, 12:08 PM Test Summary: 69146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39686
-
TYPO3com voted on patch set 7 V +1 01/03/20, 12:11 Completed build in 10m 25s on Fri, 3 Jan, 12:11 PM Test Summary: 69146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39687
-
Rudy Gnodde rebased onto patch set 8 02/10/20, 10:15
-
Anja Leichsenring commented on patch set 8 02/11/20, 14:30
PagePermissionAssembler.php:137if I read this correctly, the whole query above can be omitted if the workspace condition here matches.Feature-89917-InheritPageAccess.rst:12The feature is enabled by setting ... -
Rudy Gnodde uploaded patch set 9 02/11/20, 14:43
-
Rudy Gnodde commented on patch set 8 02/11/20, 14:43
PagePermissionAssembler.php:137ReplyDoneFeature-89917-InheritPageAccess.rst:12ReplyDone -
Rudy Gnodde uploaded patch set 10 02/11/20, 14:47
-
Rudy Gnodde commented on patch set 10 CR -1 02/11/20, 15:29
PagePermissionAssembler.php:141This won't work if there is no workspace version of the parent page. -
Rudy Gnodde uploaded patch set 11 02/11/20, 15:41
-
Rudy Gnodde commented on patch set 11 02/11/20, 15:42
PagePermissionAssembler.php:141ReplyDone -
Anja Leichsenring voted on patch set 11 V +1 CR +1 02/13/20, 09:27
-
Anja Leichsenring commented on patch set 12 02/13/20, 09:27
Published edit on patch set 11. -
Anja Leichsenring voted on patch set 12 V +1 CR +1 02/13/20, 09:27
-
TYPO3com voted on patch set 12 V +1 02/13/20, 09:41 Completed build in 14m 00s on Thu, 13 Feb, 09:41 AM Test Summary: 71262 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30
-
Benni Mack uploaded patch set 13 02/14/20, 20:15
-
Benni Mack voted on patch set 13 V +1 CR +1 02/14/20, 20:15
-
TYPO3com voted on patch set 13 V +1 02/14/20, 21:13 Completed build in 44m 51s on Fri, 14 Feb, 09:13 PM Test Summary: 71253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-86
-
Stefan Froemken commented on patch set 13 V -1 02/15/20, 11:21
Please don't use "inherit" as naming, as it has nothing to do with inherit nor recursive page access. If I create a sub-sub-page, it does NOT get the access rights of the page, where I have configured the TSConfig settings. This feature only works for direct sub-pages. So IMO you should add something like recursive, in that case "inherit" is OK to me or use another wording like "parentPage". -
Rudy Gnodde commented on patch set 13 02/17/20, 08:54
> Patch Set 13: Verified-1 > > Please don't use "inherit" as naming, as it has nothing to do with inherit nor recursive page access. If I create a sub-sub-page, it does NOT get the access rights of the page, where I have configured the TSConfig settings. This feature only works for direct sub-pages. So IMO you should add something like recursive, in that case "inherit" is OK to me or use another wording like "parentPage". It inherits the access settings from the page you're creating the new page under (or copying the page into), so "inherit" is correct in my opinion. -
Rudy Gnodde commented on patch set 13 02/20/20, 07:55
After discussing it in Slack I see your point. I'll change it to "copyFromParent" -
Rudy Gnodde uploaded patch set 14 02/20/20, 08:00
-
Markus Klein commented on patch set 14 CR -1 02/21/20, 14:05
PagePermissionAssembler.php:127what if (for whatever reason) we get an empty result? copyFromParent would fail then below (besides triggering a PHP NOTICE for the invalid array access) -
Rudy Gnodde commented on patch set 14 02/23/20, 16:12
PagePermissionAssembler.php:127ReplyThat would mean you're placing the page on the root (pid=0) or a non-existing page, but there's still a filled, non-default page tsconfig. I can't think of a scenario where that would happen that wouldn't already cause errors (like if the parent was deleted just before you're trying to create the page). -
Markus Klein commented on patch set 14 02/24/20, 09:00
PagePermissionAssembler.php:127ReplyNothing is impossible within TYPO3. ;-) Basic rule: Write safe code. So lets simply add some safety checks below? -
Rudy Gnodde uploaded patch set 15 06/06/20, 19:26
-
Rudy Gnodde commented on patch set 15 06/06/20, 19:29
PagePermissionAssembler.php:127ReplyDone -
TYPO3com voted on patch set 15 V +1 06/06/20, 19:39 Completed build in 12m 42s on Sat, 6 Jun, 07:39 PM Test Summary: 72800 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3878
-
Oliver Klee commented on patch set 15 06/06/20, 20:55
This should have tests to make sure the feature works correctly.PagePermissionAssembler.php:67You can set the field to 0 in directly in line 52. -
Rudy Gnodde uploaded patch set 16 06/07/20, 09:28
-
Rudy Gnodde commented on patch set 16 06/07/20, 09:29
PagePermissionAssembler.php:67ReplyDone -
TYPO3com voted on patch set 16 V +1 06/07/20, 09:41 Completed build in 12m 02s on Sun, 7 Jun, 09:41 AM Test Summary: 72799 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3879
-
Andreas Kienast commented on patch set 16 CR -1 07/03/20, 08:19
Could you please add functional tests? This is a very sensitive area. -
Rudy Gnodde uploaded patch set 17 08/13/21, 07:57
-
core-ci voted on patch set 17 V +1 08/13/21, 08:10 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14890
-
Oliver Klee wrote 08/13/21, 09:07
Removed reviewer Oliver Klee. -
Rudy Gnodde uploaded patch set 18 08/13/21, 09:24
-
Rudy Gnodde commented on patch set 18 08/13/21, 09:26
> Patch Set 15: > > (1 comment) > > This should have tests to make sure the feature works correctly. I don't have a lot of experience with functional tests, but I've added a test. Hope it's fine. -
core-ci voted on patch set 18 V -1 08/13/21, 09:50 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14912
-
Rudy Gnodde uploaded patch set 19 08/13/21, 09:56
-
core-ci voted on patch set 19 V +1 08/13/21, 10:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14920
-
Rudy Gnodde uploaded patch set 20 08/13/21, 12:37
-
core-ci voted on patch set 20 V +1 08/13/21, 12:53 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14957
-
Wouter Wolters commented on patch set 20 CR +1 08/13/21, 13:26
small nitpicjPagePermissionAssembler.php:109in_array should always have the 3rd parameter set to true for strict checking which is quicker and better. -
Rudy Gnodde uploaded patch set 21 08/13/21, 13:27
-
Rudy Gnodde commented on patch set 21 08/13/21, 13:28
PagePermissionAssembler.php:109ReplyDone -
Wouter Wolters voted on patch set 21 CR +1 08/13/21, 13:30
-
core-ci voted on patch set 21 V +1 08/13/21, 13:41 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14970
-
Oli Bartsch uploaded patch set 22 11/19/21, 20:52
-
core-ci voted on patch set 22 V +1 11/19/21, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19575
-
Jochen Roth voted on patch set 22 V +1 CR +1 11/22/21, 09:43
-
Oli Bartsch voted on patch set 22 V +2 CR +2 11/22/21, 12:43
-
Oli Bartsch merged patch set 23 11/22/21, 12:43