Review main Merged

62751[TASK] Apply rector set php71

Alexander Schnitzler CR +2 V +2 Hard +269 −316 updated 12/30/19, 09:26

Commit message

php bin/rector process

A couple of rectors have been disabled due to different reasons:

- Rector\Php71\Rector\FuncCall\CountOnNullRector
  This rector has been disabled as it creates rather long and
  complex structures to avoid calling count on null.

  This rector will be enabled as soon as TYPO3 uses at least
  PHP 7.3 which introduces a "is_countable" method.

- Rector\Php71\Rector\Assign\AssignArrayToStringRector
  This rector has been disabled as it does not work properly.
  The default types of parameters have been changed although
  their types could properly be inferred by a doc block or
  by value assignments.

- Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector
  This rector has been disabled as it does not work properly.
  A bug report is filed and to be found here:
  https://github.com/rectorphp/rector/issues/2454

- Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector
  This rector has been disabled as it does not work properly.
  It removed arguments in tests, especially when using
  prophecies.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 131

Show 111 more files

Review log 916

  1. Alexander Schnitzler uploaded patch set 1 12/19/19, 14:56

  2. TYPO3com voted on patch set 1 V -1 12/19/19, 14:57 Completed build in 01m 03s on Thu, 19 Dec, 02:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39534

  3. Alexander Schnitzler uploaded patch set 2 12/19/19, 15:33

  4. Alexander Schnitzler wrote 12/19/19, 15:34

    Topic set to rector
  5. TYPO3com voted on patch set 2 V -1 12/19/19, 15:42 Completed build in 08m 50s on Thu, 19 Dec, 03:42 PM Test Summary: 3 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39535

  6. TYPO3com commented on patch set 2 12/19/19, 15:49 Completed build in 24m 45s on Thu, 19 Dec, 03:49 PM Test Summary: 3 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39535

  7. Alexander Schnitzler uploaded patch set 3 12/19/19, 21:05

  8. TYPO3com voted on patch set 3 V -1 12/19/19, 21:20 Completed build in 14m 17s on Thu, 19 Dec, 09:19 PM Test Summary: 1 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39539

  9. TYPO3com voted on patch set 3 V +1 12/19/19, 21:27 Completed build in 35m 43s on Thu, 19 Dec, 09:27 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39539

  10. Alexander Schnitzler uploaded patch set 4 12/20/19, 15:56

  11. TYPO3com voted on patch set 4 V -1 12/20/19, 16:04 Completed build in 08m 18s on Fri, 20 Dec, 04:04 PM Test Summary: 7 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39550

  12. TYPO3com voted on patch set 4 V +1 12/20/19, 16:52 Completed build in 1h 04m 34s on Fri, 20 Dec, 04:52 PM Test Summary: 69127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39550

  13. Benni Mack voted on patch set 4 CR +1 12/27/19, 22:41

  14. Benni Mack voted on patch set 4 V +1 12/30/19, 09:14

  15. Anja Leichsenring voted on patch set 4 V +2 CR +2 12/30/19, 09:25

  16. Anja Leichsenring merged patch set 5 12/30/19, 09:26