Review main Merged

62752[BUGFIX] Do not pass extTarget by reference

Susi Moog CR +2 V +2 Easy +3 −1 updated 01/12/20, 16:35

Commit message

As config.extTarget might not be set, passing
it by reference results in the string "< config.extTarget"
being passed instead - which will not evaluate to empty
therefor breaking the fallback chain.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Susi Moog uploaded patch set 1 12/19/19, 16:41

  2. TYPO3com voted on patch set 1 V +1 12/19/19, 16:49 Completed build in 07m 21s on Thu, 19 Dec, 04:49 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39536

  3. Anja Leichsenring commented on patch set 1 12/19/19, 18:03

    ParseFunc.typoscript:25

    as it might be written - there is a 'not' too much here, correct? asking before editing because I am not completely sure I deciphered this sentence correctly.
  4. Susi Moog commented on patch set 1 01/12/20, 16:09

    ParseFunc.typoscript:25 Reply Unresolved

    the 'not' is on purpose if extTarget is NOT set, the string "config.extTarget" will be used as value instead resulting in target='config.extTarget' in the frontend.
  5. Daniel Goerz voted on patch set 1 V +1 CR +1 01/12/20, 16:29

  6. Markus Klein voted on patch set 1 V +1 CR +1 01/12/20, 16:32

  7. Daniel Goerz voted on patch set 1 V +2 CR +2 01/12/20, 16:35

  8. Daniel Goerz merged patch set 2 01/12/20, 16:35