Review main Merged

62754[BUGFIX] PopulatePageSlugs return the most recent slug

Herman Kremer CR +2 V +2 Easy +1 −0 updated 12/30/19, 23:50

Commit message

The populate page slugs functionality in de upgrade wizard does not
work correct for pages with multiple title adjustments.

Realurl keeps for every page title change a record in
tx_realurl_pathdata.

In order to get the latest change a order should be added to the
query in getSuggestedSlugs.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Herman Kremer uploaded patch set 1 12/20/19, 09:50

  2. TYPO3com voted on patch set 1 V -1 12/20/19, 10:07 Completed build in 16m 58s on Fri, 20 Dec, 10:07 AM Test Summary: 7 of 69572 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39548

  3. Guido Schmechel updated the commit message in patch set 2 12/22/19, 17:18

  4. TYPO3com voted on patch set 2 V -1 12/22/19, 17:26 Completed build in 07m 42s on Sun, 22 Dec, 05:26 PM Test Summary: 48710 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39556

  5. TYPO3com voted on patch set 2 V +1 12/28/19, 14:00 Completed build in 07m 49s on Sat, 28 Dec, 02:00 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39639

  6. Guido Schmechel voted on patch set 2 V +1 CR +1 12/28/19, 14:02

  7. Daniel Haupt voted on patch set 2 CR +1 12/30/19, 23:40

  8. Benni Mack voted on patch set 2 V +2 CR +2 12/30/19, 23:50

  9. Benni Mack merged patch set 3 12/30/19, 23:50