Review main Merged

62756[BUGFIX] Show argument validation results in scheduler list

Markus Klösges CR +2 V +2 Easy +13 −2 updated 01/14/20, 10:22

Commit message

The scheduler module now shows validation errors for execute console
commands as messages in the backend. Previously changing the
configuration of a console commands arguments could lead to an exception
when the currently selected set of arguments was not parseable anymore
with the new configuration.
In some circumstances it was also possible to save a task without
supplying all required arguments, which rendered the backend module
non-functional because of the exception.

Catching the exception and providing the error message helps spotting
and fixing these errors without having to manipulate the database
directly.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Markus Klösges uploaded patch set 1 12/21/19, 18:40

  2. TYPO3com voted on patch set 1 V +1 12/21/19, 18:48 Completed build in 07m 47s on Sat, 21 Dec, 06:48 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39551

  3. Benni Mack voted on patch set 1 CR +1 01/10/20, 10:09

  4. Jörg Bösche commented on patch set 1 V +1 CR +1 01/14/20, 09:27

    Verified on T3 v10.3.0-dev. Works for me. Test scenario before the patch ------------------------------------------------------- - Add new task of type "Execute console commands (scheduler)" - Add frequency of "*/30 * * * *" - Select "redirects:checkintegrity: Check integrity of redirects", for example - Save the task - Open the class "\TYPO3\CMS\Redirects\Command\CheckIntegrityCommand" and change the InputArgument from optional to required. - Run the previous created scheduler tasks - An T3 exception is thrown Test scenario after the patch (with added task before) ------------------------------------------------------- - Run the scheduler task again - A red notification with the text " Execution of task "Execute console commands (scheduler)" failed with the following message: Not enough arguments (missing: "site")." is visible and no T3 exception was thrown.
  5. Daniel Goerz voted on patch set 1 V +2 CR +2 01/14/20, 10:22

  6. Daniel Goerz merged patch set 2 01/14/20, 10:22