Review main Merged

62758[TASK] Introduce unit tests for CharsetConverter

Alexander Schnitzler CR +2 V +2 Normal +200 −0 updated 01/16/20, 15:18

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1116

  1. Alexander Schnitzler uploaded patch set 1 12/22/19, 15:59

  2. TYPO3com voted on patch set 1 V -1 12/22/19, 16:07 Completed build in 07m 10s on Sun, 22 Dec, 04:07 PM Test Summary: 69145 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39555

  3. TYPO3com voted on patch set 1 V +1 12/22/19, 16:23 Completed build in 30m 16s on Sun, 22 Dec, 04:22 PM Test Summary: 69146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39555

  4. Alexander Schnitzler uploaded patch set 2 01/12/20, 12:17

  5. Alexander Schnitzler commented on patch set 2 01/12/20, 12:17

    This change is ready for review.
  6. TYPO3com voted on patch set 2 V -1 01/12/20, 12:27 Completed build in 10m 04s on Sun, 12 Jan, 12:27 PM Test Summary: 69200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39805

  7. TYPO3com voted on patch set 2 V +1 01/12/20, 12:55 Completed build in 48m 51s on Sun, 12 Jan, 12:55 PM Test Summary: 69209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39805

  8. Jörg Bösche voted on patch set 2 V +1 CR +1 01/13/20, 11:48

  9. Susi Moog commented on patch set 2 01/13/20, 13:04

    CharsetConverterTest.php:53

    I would prefer to have separate clearly named tests instead of comments inside the one big test.
  10. Alexander Schnitzler commented on patch set 2 01/13/20, 13:38

    CharsetConverterTest.php:53 Reply Unresolved

    fair enough.
  11. Susi Moog commented on patch set 2 CR -1 01/14/20, 15:59

    -1 because of previous comments (just to prevent quick merges ;))
  12. Alexander Schnitzler uploaded patch set 3 01/16/20, 13:57

  13. TYPO3com voted on patch set 3 V +1 01/16/20, 14:09 Completed build in 11m 58s on Thu, 16 Jan, 02:09 PM Test Summary: 70433 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40045

  14. Benni Mack voted on patch set 3 V +1 CR +1 01/16/20, 15:17

  15. Susi Moog voted on patch set 3 V +2 CR +2 01/16/20, 15:18

  16. Susi Moog merged patch set 4 01/16/20, 15:18