Review main Merged

62759[FEATURE] Add galacian flag

Benni Mack CR +2 V +2 Easy +24 −1 updated 12/27/19, 21:19

Commit message

The flag for TYPO3's supported galacian is now added with the "gl.png" flag.

TYPO3 core previously had the "greenlandic" ("kl") named under the same
file, which was now renamed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1019

  1. Benni Mack uploaded patch set 1 12/23/19, 21:36

  2. TYPO3com voted on patch set 1 V -1 12/23/19, 21:45 Completed build in 08m 42s on Mon, 23 Dec, 09:45 PM Test Summary: 7 of 59160 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39559

  3. TYPO3com commented on patch set 1 12/23/19, 21:53 Completed build in 24m 55s on Mon, 23 Dec, 09:53 PM Test Summary: 241 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39559

  4. Benni Mack uploaded patch set 2 12/23/19, 22:11

  5. TYPO3com voted on patch set 2 V -1 12/23/19, 22:25 Completed build in 13m 48s on Mon, 23 Dec, 10:25 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39560

  6. TYPO3com commented on patch set 2 12/24/19, 08:19 Completed build in 10h 21m 21s on Tue, 24 Dec, 08:19 AM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39560

  7. Riccardo De Contardi commented on patch set 2 V +1 12/24/19, 10:44

    list view > add language record > now the flags for Galician and Greenland are correct.
  8. TYPO3com commented on patch set 2 12/25/19, 15:11 Completed build in 3h 21m 00s on Wed, 25 Dec, 03:11 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39560

  9. TYPO3com commented on patch set 2 12/25/19, 21:18 Completed build in 2h 27m 56s on Wed, 25 Dec, 09:18 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39560

  10. TYPO3com commented on patch set 2 12/25/19, 21:24 Completed build in 1h 40m 41s on Wed, 25 Dec, 09:24 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39560

  11. Benni Mack uploaded patch set 3 12/27/19, 14:41

  12. TYPO3com voted on patch set 3 V -1 12/27/19, 14:49 Completed build in 08m 11s on Fri, 27 Dec, 02:49 PM Test Summary: 942 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39590

  13. TYPO3com voted on patch set 3 V +1 12/27/19, 15:08 Completed build in 35m 20s on Fri, 27 Dec, 03:08 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39590

  14. Anja Leichsenring voted on patch set 3 V +1 CR +1 12/27/19, 15:48

  15. Georg Ringer voted on patch set 3 V +2 CR +2 12/27/19, 19:38

  16. Georg Ringer merged patch set 4 12/27/19, 19:38

  17. Oliver Hader voted on patch set 4 CR +1 12/27/19, 20:19

  18. Stephan Großberndt commented on patch set 4 12/27/19, 21:17

    Galacian sounds galactic to me
  19. Stephan Großberndt commented on patch set 4 12/27/19, 21:19

    Feature-89929-GalicianFlag.rst:12 Unresolved

    At least here its wrong too. Galacian-> galician.