Review main Merged

62760[TASK] Enable PharMetaDataInterceptor

Oliver Hader CR +2 V +2 Easy +22 −8 updated 01/16/20, 15:17

Commit message

Enable experimental checking of serialized Phar meta-data against
PHP objects. This would consider a Phar archive malicious in case
not only scalar values are found. A custom low-level Phar\Reader
is used in order to avoid using PHP's Phar object which would
trigger the initial vulnerability.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Benni Mack +1
  • Verified V +2 Done
    • Susi Moog +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 610

  1. Oliver Hader uploaded patch set 1 12/24/19, 11:49

  2. TYPO3com voted on patch set 1 V -1 12/24/19, 11:58 Completed build in 09m 12s on Tue, 24 Dec, 11:58 AM Test Summary: 69131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39570

  3. TYPO3com voted on patch set 1 V +1 12/24/19, 12:15 Completed build in 35m 54s on Tue, 24 Dec, 12:15 PM Test Summary: 69131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39570

  4. Oliver Hader voted on patch set 1 CR +1 12/27/19, 20:17

  5. Oliver Hader rebased onto patch set 2 01/07/20, 10:14

  6. TYPO3com voted on patch set 2 V -1 01/07/20, 10:35 Completed build in 21m 25s on Tue, 7 Jan, 10:35 AM Test Summary: 10 of 69413 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39731

  7. TYPO3com voted on patch set 2 V +1 01/16/20, 14:13 Completed build in 10m 33s on Thu, 16 Jan, 02:13 PM Test Summary: 70370 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40046

  8. Benni Mack voted on patch set 2 V +1 CR +1 01/16/20, 15:17

  9. Susi Moog voted on patch set 2 V +2 CR +2 01/16/20, 15:17

  10. Susi Moog merged patch set 3 01/16/20, 15:17