62761[TASK] Check spool filepath in the install tool
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1524
-
Guido Schmechel uploaded patch set 1 12/24/19, 12:15
-
TYPO3com voted on patch set 1 V -1 12/24/19, 12:15 Completed build in 13s on Tue, 24 Dec, 12:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39571
-
Guido Schmechel uploaded patch set 2 12/24/19, 12:20
-
TYPO3com voted on patch set 2 V +1 12/24/19, 12:27 Completed build in 07m 16s on Tue, 24 Dec, 12:27 PM Test Summary: 69128 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39572
-
Oliver Klee commented on patch set 2 12/24/19, 14:36
DefaultFactory.php:246Please let's make this a guard clause. -
Guido Schmechel uploaded patch set 3 12/25/19, 09:04
-
TYPO3com voted on patch set 3 V -1 12/25/19, 09:11 Completed build in 06m 59s on Wed, 25 Dec, 09:11 AM Test Summary: 190 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39573
-
Guido Schmechel commented on patch set 3 12/25/19, 09:15
DefaultFactory.php:244ReplyDoneDefaultFactory.php:246ReplyI had once looked at 1-2 examples. Do you mean the structure like this? -
Oliver Klee commented on patch set 3 12/25/19, 09:27
DefaultFactory.php:246ReplyI was thinking along the lines of this: if (empty($GLOBALS['TYPO3_CONF_VARS']['MAIL']['transport_spool_filepath'])) { return $structure; } -
Guido Schmechel commented on patch set 3 12/25/19, 09:48
DefaultFactory.php:246Reply UnresolvedOK. This is now available in patch set 3. -
TYPO3com commented on patch set 3 12/25/19, 10:07 Completed build in 10m 04s on Wed, 25 Dec, 10:07 AM Test Summary: 673 of 68453 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39574
-
TYPO3com commented on patch set 3 12/28/19, 09:50 Completed build in 07m 09s on Sat, 28 Dec, 09:50 AM Test Summary: 68858 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39638
-
TYPO3com voted on patch set 3 V +1 02/22/20, 19:10 Completed build in 35m 41s on Sat, 22 Feb, 07:09 PM Test Summary: 71580 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-503
-
Susi Moog rebased onto patch set 4 02/28/20, 08:31
-
Susi Moog voted on patch set 4 CR +1 02/28/20, 08:34
-
TYPO3com voted on patch set 4 V -1 02/28/20, 08:42 Completed build in 10m 56s on Fri, 28 Feb, 08:42 AM Test Summary: 1 of 72488 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-771
-
TYPO3com voted on patch set 4 V +1 02/28/20, 08:45 Completed build in 24m 32s on Fri, 28 Feb, 08:45 AM Test Summary: 72003 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-771
-
Susi Moog commented on patch set 4 V -1 CR 0 02/28/20, 16:31
if I set the filepath to something like "/foo/bar/baz" that gets created in the public folder of my installation - which is a bad idea because - it's public - and the spool setting is searching for the absolute path /foo/bar/baz -
Guido Schmechel commented on patch set 4 03/14/20, 14:16
Hi Susanne, thanks for your hint. I looked at the description of the entry. It says: "Path where messages get temporarily stored. Ensure that this is stored outside of your webroot." Of course there is no check there. I would have no problem in forcing this into the var folder for this function. We have to change the field description, too. What do you think? -
Guido Schmechel commented on patch set 4 03/14/20, 14:17
Addendum: This could of course conflict with existing attitudes and could be breaking. -
Benni Mack uploaded patch set 5 04/30/20, 07:13
-
TYPO3com voted on patch set 5 V +1 04/30/20, 07:28 Completed build in 14m 43s on Thu, 30 Apr, 07:28 AM Test Summary: 73663 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3115
-
Benni Mack updated the commit message in patch set 6 05/25/20, 18:48
-
Guido Schmechel abandoned the change 09/26/20, 12:04
DefaultFactory.php:244