Review main Abandoned

62762[FEATURE] Media Renderer cleanup

Mario Lubenka CR 0 V 0 Hard +487 −488 updated 11/03/21, 16:55

Commit message

Refactor renderers so that parts can be overwritten easier

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 9

Review log 710

  1. Mario Lubenka uploaded patch set 1 12/25/19, 13:14

  2. TYPO3com voted on patch set 1 V -1 12/25/19, 13:14 Completed build in 12s on Wed, 25 Dec, 01:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39575

  3. Oliver Klee commented on patch set 1 12/25/19, 13:51

    Also, please let's have parameter and return type declarations for the new code.

    AbstractHtmlMediaRenderer.php:2

    strict mode, please.

    AbstractOnlineVideoRenderer.php:2

    strict mode, please.
  4. Mario Lubenka uploaded patch set 2 12/25/19, 15:14

  5. TYPO3com voted on patch set 2 V -1 12/25/19, 15:15 Completed build in 12s on Wed, 25 Dec, 03:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39576

  6. Mario Lubenka commented on patch set 2 12/25/19, 15:16

    AbstractHtmlMediaRenderer.php:2 Reply

    Done

    AbstractOnlineVideoRenderer.php:2 Reply

    Done
  7. Mario Lubenka commented on patch set 2 12/25/19, 15:18

    > Patch Set 1: > > (2 comments) > > Also, please let's have parameter and return type declarations for the new code. Sure! I guess I missed some spots. ;) Should be fixed now.
  8. TYPO3com commented on patch set 2 02/22/20, 18:34 Completed build in 34s on Sat, 22 Feb, 06:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-500

  9. Alexander Schnitzler commented on patch set 2 CR -1 03/08/20, 11:23

    AbstractHtmlMediaRenderer.php:22 Unresolved

    Please don't introduce abstract classes without interfaces that describe what those abstract classes are to be used for. What you do here is to avoid an interface that defines behavior of all renderers that render HTML media elements. You circumvent this by defining properties that need to be overridden in concrete classes. This is quite unsafe because you don't know if the concrete class does so. And while implementing a sub class I don't know that I have to do it. That's what interfaces are for. Please create interfaces that define how a renderer behaves and let the abstract class only do the work that can be shared across multiple renderers.

    AbstractOnlineVideoRenderer.php:151 Unresolved

    This possibly results in a "call member function getOnlineMediaId on null" Exception.

    AbstractOnlineVideoRenderer.php:190 Unresolved

    This looks like a good fit for a constant or static variable.

    AbstractOnlineVideoRenderer.php:192 Unresolved

    Do you really mean to check for emptiness here rather for existence? This possibly throws errors in PHP 7.4
  10. Oli Bartsch abandoned the change 11/03/21, 16:55

    No activity since more than a year now. Feel free to restore once the known comments have been addressed.