Review main Merged

62764[TASK] Clean up BasicFileUtility

Benni Mack CR +2 V +2 Normal +41 −76 updated 01/09/20, 14:37

Commit message

The BasicFileUtility was very important before the FAL API was introduced
in TYPO3 v6. Since TYPO3 v10, the last important parts have been
removed, which is why the PHP class is now marked as internal.

In addition, several internal methods have been removed, the
"setFileExtensionPermission" method is still there in order to avoid
PHP Fatal Errors so extensions can stay compatible with TYPO3 v9 and TYPO3 v10.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 814

  1. Benni Mack uploaded patch set 1 12/27/19, 07:18

  2. TYPO3com voted on patch set 1 V -1 12/27/19, 07:25 Completed build in 07m 44s on Fri, 27 Dec, 07:25 AM Test Summary: 68834 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39580

  3. TYPO3com voted on patch set 1 V +1 12/27/19, 09:06 Completed build in 1h 55m 40s on Fri, 27 Dec, 09:06 AM Test Summary: 69127 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39580

  4. Benni Mack updated the commit message in patch set 2 12/27/19, 15:13

  5. TYPO3com voted on patch set 2 V -1 12/27/19, 15:22 Completed build in 09m 10s on Fri, 27 Dec, 03:22 PM Test Summary: 107 of 69578 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39594

  6. Benni Mack uploaded patch set 3 12/27/19, 15:34

  7. TYPO3com voted on patch set 3 V +1 12/27/19, 15:42 Completed build in 07m 53s on Fri, 27 Dec, 03:42 PM Test Summary: 69126 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39597

  8. Anja Leichsenring voted on patch set 3 V +1 CR +1 12/27/19, 15:50

  9. Benni Mack uploaded patch set 4 12/31/19, 11:51

  10. TYPO3com voted on patch set 4 V -1 12/31/19, 12:03 Completed build in 08m 28s on Tue, 31 Dec, 12:03 PM Test Summary: 68853 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39678

  11. TYPO3com voted on patch set 4 V +1 12/31/19, 12:07 Completed build in 20m 52s on Tue, 31 Dec, 12:07 PM Test Summary: 69134 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39678

  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 01/09/20, 12:37

  13. Georg Ringer voted on patch set 4 V +2 CR +2 01/09/20, 14:37

  14. Georg Ringer merged patch set 5 01/09/20, 14:37