Review main Merged

62769[FEATURE] Expose internal typoLinkParts in TypolinkViewHelper

Oliver Hader CR +2 V +2 Normal +96 −2 updated 02/22/20, 17:09

Commit message

Parameters being generated internally by TypoLink using
`<f:link.typolink parts-as="typoLinkParts">` view helper are
exposed as variable and can be used in Fluid templates again,
which are:

* url
* target
* class
* title
* additionalParams

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 1725

  1. Oliver Hader uploaded patch set 1 12/27/19, 10:30

  2. TYPO3com voted on patch set 1 V -1 12/27/19, 10:39 Completed build in 09m 33s on Fri, 27 Dec, 10:39 AM Test Summary: 1817 of 69581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39583

  3. Oliver Hader voted on patch set 1 CR -1 12/27/19, 20:15

  4. Oliver Hader commented on patch set 1 12/27/19, 20:15

    Needs some refactoring first...
  5. Oliver Hader commented on patch set 1 12/27/19, 20:15

  6. Oliver Hader uploaded patch set 2 12/27/19, 20:51

  7. Oliver Hader uploaded patch set 3 12/27/19, 20:53

  8. TYPO3com voted on patch set 3 V -1 12/27/19, 20:59 Completed build in 04m 32s on Fri, 27 Dec, 08:59 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39614

  9. TYPO3com voted on patch set 2 V -1 12/27/19, 21:01 Completed build in 09m 41s on Fri, 27 Dec, 09:01 PM Test Summary: 3 of 69581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39612

  10. Oliver Hader updated the commit message in patch set 4 12/27/19, 21:01

  11. Oliver Hader commented on patch set 4 CR -1 12/27/19, 21:10

  12. TYPO3com voted on patch set 4 V -1 12/27/19, 21:30 Completed build in 05m 46s on Fri, 27 Dec, 09:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39620

  13. Benni Mack commented on patch set 4 01/30/20, 12:17

    That one would be ready now!
  14. Oliver Hader rebased onto patch set 5 02/01/20, 18:09

  15. Oliver Hader voted on patch set 5 CR -1 02/01/20, 18:09

  16. TYPO3com voted on patch set 5 V -1 02/01/20, 18:19 Completed build in 10m 01s on Sat, 1 Feb, 06:19 PM Test Summary: 1246 of 71659 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40459

  17. Oliver Hader uploaded patch set 6 02/02/20, 10:05

  18. TYPO3com voted on patch set 6 V -1 02/02/20, 10:05 Completed build in 13s on Sun, 2 Feb, 10:05 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40467

  19. Oliver Hader uploaded patch set 7 02/02/20, 10:08

  20. TYPO3com voted on patch set 7 V +1 02/02/20, 10:19 Completed build in 11m 16s on Sun, 2 Feb, 10:19 AM Test Summary: 71250 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40468

  21. Oliver Hader uploaded patch set 8 02/22/20, 15:49

  22. TYPO3com voted on patch set 8 V +1 02/22/20, 16:20 Completed build in 29m 05s on Sat, 22 Feb, 04:20 PM Test Summary: 71523 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-482

  23. Susi Moog voted on patch set 8 V +1 CR +1 02/22/20, 16:48

  24. Andreas Kienast voted on patch set 8 V +2 CR +2 02/22/20, 17:09

  25. Andreas Kienast merged patch set 9 02/22/20, 17:09